Repository navigation
Choose a format to convert to when syncing a USB - #18
Merged
Merged
Conversation
The sync dialog offers the conversion presets, defaulting to no conversion. The choice is part of the review, so changing it reviews again, and the summary says how many tracks would be converted, copied or removed, or that the USB is already up to date. Converting shows its own progress.
There was a problem hiding this comment.
🟢 Approval recommended
The preset is consistently passed through review and sync, and no unresolved issues were identified in the three changed files.
No open issues 🎉
What changed in this PR
Adds the USB-sync conversion UI on top of the existing backend, allowing users to choose an audio preset without changing library files.
Changes:
- Adds a conversion preset picker and includes the selection in review refreshes.
- Passes the optional preset through the API and library sync methods.
- Displays planned copy, conversion, and removal counts, plus conversion progress.
| File | Description |
|---|---|
app/src/renderer/src/lib/library.svelte.ts |
Forwards the optional conversion preset to USB sync. |
app/src/renderer/src/lib/components/SyncDialog.svelte |
Adds preset selection, review updates, plan summaries, and conversion progress. |
app/src/renderer/src/lib/api.ts |
Accepts conversion presets for USB review and sync requests. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 6 (last) of the "convert audio on USB export" series. Stacked on #17.
UI for converting on USB sync.
reviewKey), so changing it re-runs the review; review and sync are always given the same preset, so the review token matches.Up to date · no changes, or e.g.3 to convert · 1 to copy · 2 to remove, orNo audio to copy or convert. Syncing again with the same format as last time shows no conversions or copies.convertphase → "Converting 4 of 20 · Title".api.usbSyncReview/api.usbSync/library.syncTotake an optional preset.Typecheck/svelte-check clean; no new lint errors (the file's existing prettier warnings are unchanged).
Manual check suggested: sync a playlist with a WAV and an MP3 using an MP3 preset → USB shows the WAV as
.mp3, library still points at the WAV; reopen the dialog with the same preset → summary shows no conversions or copies; switch to "Don't convert" → summary shows 1 to copy.