Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published Bedrock adapter drops complete tool calls when the same response ends with
max_tokens, even though it emits identical arguments fortool_use. Parse stopped tool blocks at the length terminal with the existing secure parser, preserve complete calls, and retain the original finish reason and usage.Incomplete, empty, and unsafe argument buffers remain parameter deltas at the length terminal. Normal completion keeps its existing parse-error behavior. This change adds no execution or transport retry policy.
This PR targets
feat/ai-bedrock, the source branch whose commit08590cdf2cmatches the published@tardie/ai-bedrock@0.0.1source. The package is absent fromclavia/ai-providers.Validation: the portable public-layer reproduction fails against the published package and passes with the generated installation patch; all 19 Bedrock provider tests, package TypeScript check, formatting, and repository
pnpm checkpass. The regression includes complete, partial, unsafe, and empty buffers in one length-completed stream and verifies usage.