Bump cmake_minimum_required for compatibility with modern CMake - #66
Open
jmccrae wants to merge 1 commit into
Open
Bump cmake_minimum_required for compatibility with modern CMake#66jmccrae wants to merge 1 commit into
jmccrae wants to merge 1 commit into
Conversation
CMake 3.5+ removed compatibility with the VERSION 2.8 policy, so configuring with recent CMake releases (e.g. 4.x) fails outright. Also fixes a dead link to the CMake homepage in the README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CMakeLists.txtpinnedcmake_minimum_required(VERSION 2.8). CMake 3.5+ dropped compatibility with policies older than 2.8.12, so configuring with a modern CMake (e.g. 4.x) fails immediately withCompatibility with CMake < 3.5 has been removed from CMake.Bumped toVERSION 3.10and moved it ahead ofproject()per current CMake guidance.[CMake]()link in the README, pointing it at cmake.org.Test plan
mkdir build && cd build && cmake .. && makecompletes successfully with CMake 4.2.3 / GCC 15.2.0./fast_alignand./atoolsrun and print usagefast_align -i <example corpus> -d -o -von the German–English example from the README and got sane alignments🤖 Generated with Claude Code