Handle attached Docker run output - #61
Open
X1pheR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handle the Docker SDK return type for
run_container(detach=false)instead of passing attached command output todocker_to_dict().Problem
docker.containers.run(..., detach=False)returns command output bytes. The current tool always callsdocker_to_dict()on the result, which only supports Docker model objects, so attached execution fails during result conversion even when the command itself succeeded.Change
{mode: "attached", output: ...}data.This PR intentionally does not add output-size policy; it only fixes the Docker SDK type contract.
Validation
ruff check src testspytest -q: 6 passedalpine:latestanddetach=falsereturned the expected command output successfully.