Clean up Docker build intermediates - #60
Open
X1pheR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pass Docker SDK
rm=Trueandforcerm=Truefrom thebuild_imagetool so intermediate containers are removed on both successful and failed image builds.Problem
docker.images.build()defaults do not force intermediate-container cleanup. Repeated MCP builds can therefore leave non-Compose intermediate containers behind, especially after failures.Change
Add the two Docker SDK cleanup flags to the existing build call and extend the hermetic call-contract assertion.
Validation
ruff check src testspytest -q: 6 passed