Omit unset values from Docker SDK filters - #59
Open
X1pheR wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Omit unset optional fields when converting typed MCP filter models into Docker SDK filter dictionaries.
Problem
ListImagesFilters(dangling=True)currently becomes{"dangling": true, "label": null}. With Docker SDK 7.1.0 against a live daemon, that changes the result from the expected dangling-image set to an empty result.Observed against the same daemon:
{"dangling": true}-> 29 images{"dangling": true, "label": null}-> 0 images{"dangling": true, "label": []}-> 29 imagesThe same issue can affect the optional label fields on container and network filters.
Change
Add one small
_docker_filters()normalization boundary usingmodel_dump(exclude_none=True)and use it for container, image and network list calls.The hermetic tests now verify that empty filter objects remain empty and that a dangling-only image filter reaches the Docker SDK as exactly
{"dangling": true}.Validation
ruff check src testspytest -q: 6 passed