Support Rails 7.2, 8.0 and 8.1 (collects the open fix PRs, CI green on 6.0-8.1)

[tachyurgy]

This gets master green on every Rails version from 6.0 to 8.1 (Ruby 3.0 to 3.4, Citus 10/11/12), so that a release can finally go out. #265 and #268 are people blocked on exactly that.

Most of it is work that was already sitting in open PRs here. I cherry-picked those with the original authors kept on the commits, and added what was still missing to get the suite passing.

From open PRs (authors credited on their commits)

• Ensure Rails versions are actually tested #264 (Matt Larraz (@mlarraz)): CI actually installs each appraisal gemfile, so the matrix tests the Rails version it says it does
• Fix Arel visitor compatibility with Rails 8.1 #284 (Krzysztof Adamski (@rience)): Arel visitor compatibility with Rails 8.1
• Fixes issues with update_all, increment, and decrement #282 (Sergio Medina (@serch)): update_all with Arel.sql, increment_counter / update_counters / increment! / decrement! inside MultiTenant.with (fixes Bug: Arel.sql in update_all becomes a literal value inside MultiTenant.with #278 and Bug: ActiveRecord::Base.increment_counter within a multi-tenant context, the counter column is set to NULL instead of being incremented #279), plus bumping the lock column
• Fix SystemStackError when extending ActiveRecord::SchemaDumper#initialize with Module#prepend #271 (Shinichi Maeshima (@willnet)): SystemStackError in the schema dumper when another gem prepends to ActiveRecord::SchemaDumper (also proposed in Replace Alias Method Chain With Prepend for SchemaDumper #245)
• Fix TypeError: Cannot visit Arel::SelectManager when executing a subquery with Arel #236 (Ken Muryoi (@muryoimpl)): TypeError: Cannot visit Arel::SelectManager for Arel subqueries
• Add Rails 8.0 support to README #280 (Tsukuru Tanimichi (@ttanimichi)): README mentions Rails 8.0
• Fix unintended side effects of delete_all and update_all with multi-tenancy for non-multi-tenant models #269 (B6 (@a5-stable)): call the original delete_all for models that are not multi-tenant

New in this PR

• Rails 8.1 and Ruby 3.4 in the matrix (8.x on Ruby 3.2+, 7.2 on 3.1+, 6.x not on 3.4, matching what Rails supports)
• build_arel was called with the wrong arguments on Active Record 6.0 and 8.1, so update_all / delete_all inside MultiTenant.with raised on both. The four real signatures are (aliases) on 6.0, (aliases = nil) on 6.1 to 7.1, (connection, aliases = nil) on 7.2 and 8.0, and (aliases) again on 8.1.
• Rails 8.1 compiles a joined update_all as UPDATE ... FROM with a self-join on the primary key, which Citus rejects ("complex joins are only supported when all distributed tables are co-located"). For multi-tenant models the self-join now also matches on the partition key, which Citus can route. Older Rails never builds that alias, so nothing changes there.
• The SelectManager visit from Fix TypeError: Cannot visit Arel::SelectManager when executing a subquery with Arel #236 also needed to apply on Rails 6.0
• Specs for Arel functions in tenant-scoped conditions, the schema dumper with strong_migrations' load order, and the update_all regressions
• require 'logger' before Rails in the spec helper (needed on newer Ruby with Rails 6.x/7.0), RuboCop pinned so the static check is reproducible
• CHANGELOG Unreleased section listing all of the above

Every commit is small and runs green on its own, so it's easy to review one at a time or to drop anything you'd rather not take.

Green run on my fork: https://github.com/tachyurgy/activerecord-multi-tenant/actions/runs/36967652491

Since there is no release in the meantime, I've also published this branch as activerecord-multi-tenant-next so people stuck on Rails 7.2+ have something installable from RubyGems. Same MultiTenant API and require path. I'd much rather it go out here as 2.5.0, and I'm happy to help maintain this gem if that would be useful (more on #268).

[microsoft-github-policy-service]

tachyurgy please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

1. Definitions.
   “Code” means the computer software code, whether in human-readable or machine-executable form,
   that is delivered by You to Microsoft under this Agreement.
   “Project” means any of the projects owned or managed by Microsoft and offered under a license
   approved by the Open Source Initiative (www.opensource.org).
   “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
   Project, including but not limited to communication on electronic mailing lists, source code control
   systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
   discussing and improving that Project, but excluding communication that is conspicuously marked or
   otherwise designated in writing by You as “Not a Submission.”
   “Submission” means the Code and any other copyrightable material Submitted by You, including any
   associated comments and documentation.
2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
   Project. This Agreement covers any and all Submissions that You, now or in the future (except as
   described in Section 4 below), Submit to any Project.
3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
   Should You wish to Submit materials that are not Your original work, You may Submit them separately
   to the Project if You (a) retain all copyright and license information that was in the materials as You
   received them, (b) in the description accompanying Your Submission, include the phrase “Submission
   containing materials of a third party:” followed by the names of the third party and any licenses or other
   restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
   guidelines concerning Submissions.
4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
   for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
   Submission is made in the course of Your work for an employer or Your employer has intellectual
   property rights in Your Submission by contract or applicable law, You must secure permission from Your
   employer to make the Submission before signing this Agreement. In that case, the term “You” in this
   Agreement will refer to You and the employer collectively. If You change employers in the future and
   desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
   and secure permission from the new employer before Submitting those Submissions.
5. Licenses.

• Copyright License. You grant Microsoft, and those who receive the Submission directly or
  indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
  Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
  the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
  parties.
• Patent License. You grant Microsoft, and those who receive the Submission directly or
  indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
  Your patent claims that are necessarily infringed by the Submission or the combination of the
  Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
  import or otherwise dispose of the Submission alone or with the Project.
• Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
  No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
  granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
   licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
   have disclosed under Section 3). You represent that You have secured permission from Your employer to
   make the Submission in cases where Your Submission is made in the course of Your work for Your
   employer or Your employer has intellectual property rights in Your Submission by contract or applicable
   law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
   have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
   You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
   REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
   EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
   PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
   NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
7. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
   You later become aware that would make Your representations in this Agreement inaccurate in any
   respect.
8. Information about Submissions. You agree that contributions to Projects and information about
   contributions may be maintained indefinitely and disclosed publicly, including Your name and other
   information that You submit with Your Submission.
9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
   the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
   Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
   exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
   defenses of lack of personal jurisdiction and forum non-conveniens.
10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

[Sergio Medina (serch)]

fantastic PR thanks tachyurgy! hope you are added as maintainer of the gem 🤞