Repository navigation
fix(resenv): correct worker shutdown and PR artifact verification - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
resenv runwraps a command that starts a worker, signaling only the immediate command can leave that worker running and hang shutdown. Forward POSIX shutdown signals to the command's isolated process group, preserving direct child signaling on Windows and tolerating groups that have already exited.PR builds check out the head commit, while GitHub's
GITHUB_SHAidentifies a synthetic merge commit. Verify candidate identity against the actual checkout so all matrix jobs can test the same archive without weakening the source-commit or integrity checks.Allow up to four minutes for GitHub to process PR coverage after the observed 160-second timeout; upload and processing failures remain blocking.
Extend the existing three-signal regression to cover both the command and its worker. Align maintainer instructions with requested PR delivery through a temporary task branch, and record the decision to skip live Doppler account approval.
Validation on Node 24.19.0:
npm run verify: lint, strict types, build, 101 unit/tooling tests, 41 process tests, 16 packed runtime checks and two typed consumers passed.npm run audit: zero runtime findings; the 12 bounded development exceptions and November 9 expiry remain unchanged.