Robustness, reproducibility & dependency-safety improvements - #85
Merged
Merged
Conversation
chrieke
force-pushed
the
streamlit-osm-importerror
branch
2 times, most recently
from
July 8, 2026 14:09
458ba76 to
e629508
Compare
Merged
- Replace private geopandas.plotting functions with public matplotlib collections (PatchCollection/LineCollection, polygon holes honored). - Use the stable top-level osmnx API (ox.geocode, ox.features_from_polygon) instead of submodule imports; bound osmnx<3; declare geopandas/shapely as direct dependencies. - Add dpi parameter to Plot (default 300, was hardcoded 1200) for much faster, lower-memory rendering. - Seed building color variation so identical inputs render identical maps; custom cmaps use all their colors instead of the first 3. - Translate osmnx InsufficientResponseError into OsmDataError. - Vectorize explode_multigeometries (was quadratic), preserve input CRS. - Fix ineffective geocode mocks that silently hit the live Nominatim service on every test run; correct expected values. - Add offline tests for the full Plot rendering pipeline; tests now run from any working directory. - Add GitHub Actions CI (format, lint, type-check, test, build). - Modernize Makefile to uv; ship LICENSE in the wheel; exclude tests from the wheel; upgrade yanked numpy 2.4.0. - Install the library from local source in the Dockerfile so app and package cannot drift apart. - Fix README/notebook examples that mutated global settings via shallow copy; use None-sentinel defaults instead of mutable dict defaults. - Clean up stale examples.json entries.
chrieke
force-pushed
the
streamlit-osm-importerror
branch
from
July 8, 2026 14:12
e629508 to
e1a10b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code-only changes. The version bump + CHANGELOG +
requirements.txtpin for the 0.7.0 release are in a separate PR, to be merged after this one.Summary
geopandas.plottingfunctions with public matplotlib collections, and use the stable top-levelosmnxAPI instead of submodule imports — avoids breakage on dependency upgrades.dpiparameter toPlot(default 300, was hardcoded 1200) — much faster, lower-memory rendering; libraryfig.savefig()no longer silently produces ~14,400px files.InsufficientResponseErrorintoOsmDataError; vectorizeexplode_multigeometries(was quadratic).osmnx<3; declaregeopandas/shapelyas direct dependencies.Plotpipeline; add GitHub Actions CI.Test plan
black,pylint,mypy,pytestall pass (offline). Package builds. Full Streamlit app runs end-to-end on live OSM data with no errors.