Skip to content

FEAT: integrate sparrowpy method - #12

Merged
mberz merged 46 commits into
choras-org:developfrom
ahms5:dev_sparrowpy
Aug 31, 2026
Merged

FEAT: integrate sparrowpy method #12
mberz merged 46 commits into
choras-org:developfrom
ahms5:dev_sparrowpy

Conversation

@ahms5

@ahms5 ahms5 commented May 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR includes sparrowpy into the simulation-backend.

it woudnt work without the other prs:

Limitations:

  • assumes scattering coefficents to be 1.
  • only for convex geometries, as the normals have to point into the room.
  • Due to the implementation of this integration, sparrowpy has to resimulate everthing on any change. Sparrowpy itself is able to split the simulation into differnent parts, so that smaller changes of the simulation can be computed much more efficently.

This was referenced May 12, 2026
Closed
Closed
@ahms5

ahms5 commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

I tried to rebase to develop, it crashed. Feel free to rebase.

@ahms5

ahms5 commented Aug 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

todo:

  • change to GPLv3
  • generate impulse response

mberz
mberz reviewed Aug 27, 2026
View reviewed changes
Comment thread example_settings/sparrowpy_setting.json
@ahms5
ahms5 requested a review from mberz August 27, 2026 12:24
@mberz
mberz merged commit 9714a20 into choras-org:develop Aug 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mberz mberz mberz approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahms5 @mberz