Skip to content

Update CI to work on modern GitHub Actions - #32

Merged
jackkoenig merged 7 commits into
chipsalliance:masterfrom
tynan-jdwk:update-ci
Sep 1, 2026
Merged

jackkoenig merged 7 commits into
chipsalliance:masterfrom
tynan-jdwk:update-ci

Conversation

@tynan-jdwk

Copy link
Copy Markdown
Contributor

I would love to have a new release of espresso created, but the GitHub Actions settings were quite out of date. Getting those updated and passing required making a few edits to resolve warnings with modern tool versions.

@tynan-jdwk

Copy link
Copy Markdown
Contributor Author

@sequencer @jerryz123 Not sure if either of you are still watching this repo, but could one of you review this please? I would like to have an espresso binary release that contains the changes since 2.4 was released.

Comment thread espresso/mincov.c
#define USE_INDEP_SET

static int select_column();
static int select_column(sm_matrix *A, int *weight, solution_t *indep);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackkoenig I remember you were curious about this change. This just makes the pre-declaration here match the real function definition at line 111 of this file.

@jackkoenig jackkoenig left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jackkoenig
jackkoenig merged commit ba3c832 into chipsalliance:master Sep 1, 2026
6 checks passed
@tynan-jdwk
tynan-jdwk deleted the update-ci branch September 1, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants