test(e2e): add Obsidian runtime coverage#172
Merged
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
3f2d672
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://af516a99.podnotes.pages.dev |
| Branch Preview URL: | https://codex-add-obsidian-e2e-tests.podnotes.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 732cfd4432
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a local Obsidian-backed E2E layer for PodNotes using
obsidian-e2e@0.6.0.This covers the runtime paths that are hard to validate in jsdom: plugin readiness, command and protocol registration, opening the PodNotes view, timestamp URI playback including
time=0, already-loaded episode seeking, timestamp capture into an editor note, and persisted/clamped volume settings.The suite is intentionally local-only for this pass. It runs behind
npm run test:e2e, builds first, locks the target vault, creates a sandbox under__obsidian_e2e__, restores PodNotesdata.json, captures failure artifacts under.obsidian-e2e-artifacts, and fails during preflight if the dev vault plugin symlinks do not point at the current checkout. No required CI check is added.Reviewer context: the tests use local sandbox episode records and media-event shims so assertions stay focused on PodNotes runtime behavior rather than external feeds or browser codec playback. The large lockfile delta comes from adding
obsidian-e2e@0.6.0and its transitive dependencies.Verified locally with
npm run lint,npm run format:check,npm run typecheck,npm run test,npm run build, and a fullnpm run test:e2erun after temporarily pointing the dev vault symlinks at this checkout. A plainnpm run test:e2efails early as intended when the dev vault points at another worktree.