fix(timestamps): keep links working after played#169
Merged
Conversation
Deploying podnotes with
|
| Latest commit: |
ac05f57
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://81282066.podnotes.pages.dev |
| Branch Preview URL: | https://fix-166-played-timestamp-lin.podnotes.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
chhoumann
force-pushed
the
fix/166-played-timestamp-links
branch
from
e042ed7 to
ac05f57
Compare
|
🎉 This PR is included in version 2.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep timestamp URI clicks from being overridden by a saved finished playback position.
When a timestamp link loads an episode that has already been marked as played, PodNotes now carries the requested timestamp through to the player and applies it after media metadata loads, before restoring saved playback progress. Already-visible linked episodes also seek and resume immediately. This also preserves
time=0timestamp links when generating PodNotes URIs.Focused tests cover the URI handler handoff and the player restore path for finished episodes. I also verified the fix in the Obsidian dev vault with a linked timestamp after marking the episode played.
Fixes #166