Skip to content

feat(compat): support DSH 0.2.2-rc.4 - #32

Merged
cherrchen merged 2 commits into
mainfrom
feat/adapt-1118
Nov 18, 2026
Merged

cherrchen merged 2 commits into
mainfrom
feat/adapt-1118

Conversation

@cherrchen

@cherrchen cherrchen commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Summary

Extends the verified compatibility range from 0.2.2-rc.3 to the upstream tag dsh-v0.2.2-rc.4, the current 0.2.2 release candidate. The development pin and committed lockfile stay on 0.2.0-rc.2.

0.2.2-rc.4 is a content-safety release: the only plugin-facing change is the new CONTENT_REFUSED LLM failure code, which this plugin does not classify, so the adaptation is declarative (release list, peer ORs, engines.dsh, CI lane) plus the seam review and published-package evidence.

Interface review (upstream tags)

  • dsh-v0.2.2-rc.3 (38a6a5c965) → dsh-v0.2.2-rc.4 (3f321d32bf): 8 commits, 395 files changed in the tree, 117 in the directories this plugin consumes, and of those 110 are manifest version re-issues. vendor/ is untouched.
  • Substantive upstream changes: the DeepSeek adapter maps a refusal stop reason to the new CONTENT_REFUSED failure code (previously MALFORMED_RESPONSE) and reports billed usage before failing, recorded in the new upgrade guide docs/upgrade-guide/v0.2.2-rc.3/deepseek-refusal-code/; the experimental liveshare tunnel worker inherits the Host's ELECTRON_RUN_AS_NODE.
Seam Result
Commit message / LLM dsh-llm adds one CONTENT_REFUSED entry to LLM_FAILURE_CODES. GenerateOptions, LlmRuntime.stream, Message, MessageId, TextBlock, text-delta and finish are unchanged. The plugin imports no failure-code enum and branches on no code: the RPC adapter maps any generation error to git/internal and surfaces the message, so a refusal keeps the existing failure path. No src/compat/ branch.
Client packages / slots ui-conversation, ui-session, ui-settings, ui-settings-plugins, ui-sidebar-right, ui-renderer, ui-slots, ui-primitives, client-connection, client-locale, client-resources and api-session-controller: manifest-only. The Menu anchor interface, plugin-used primitives, openTab / openResource, useSessions(...byId[id].cwd) and configForms.get are unchanged.
Host Git / subprocess / credentials / settings / workspace dsh-subprocess, dsh-subprocess-local, dsh-credentials, dsh-settings, dsh-workspace, dsh-fs, dsh-working-directory and experimental/worktree: manifest-only. resolveExecutable / spawn, separate argv, credential key/ref and worktree probes unchanged.
liveshare tunnel worker Experimental fix only; this plugin does not import or register the package.
Shared runtime Cordis 4.1.0, cosmokit 1.9.0, schemastery 3.19.0 — identical to rc.3, already inside the declared ranges; no new OR clause.
Node rc.4 still declares Node >=24.9.0; the lane joins the other 0.2.2 hosts on Node 24.9.0.

Adaptation

  • Declarations. 0.2.2-rc.4 added to SUPPORTED_DSH_RELEASES, CREDENTIALS_SEAM_DSH_RELEASES, every DSH peer OR and engines.dsh.
  • CI. 0.2.2-rc.4 joins the 0.2.2 Node 24.9.0 lane list in .github/workflows/upgrade.yml.
  • No compat branch. No src/ file changed in this PR; the plugin imports only LLM types and never classifies failure codes.
  • Not added to peer OR. No plugin peer was added or removed.

Validation

Published packages:

  • @deepseek-ai/dsh@0.2.2-rc.4 is on npm since 2026-11-17T17:03:03Z (dist-tag next; latest remains 0.2.2-rc.1), and every declared DSH peer is published at 0.2.2-rc.4.
  • Tarball comparison rc.3 vs rc.4 (36 tarballs, sha1 and sha512 matched the registry dist metadata for all of them): 16 of 18 packages differ only in package.json; dsh-client-ui-primitives is byte-identical except its manifest (Menu still reads anchorRef / anchorPoint, zero getAnchorRect in lib/; all 12 value exports, 6 type exports and 9 glyphs retained); dsh-api-session-controller's lib/typert.host.js did not change. dsh-llm is the only peer with a code delta: one CONTENT_REFUSED line in LLM_FAILURE_CODES (lib/index.js, lib/types/error.d.ts, lib/types/error.js, src/error.ts plus two sourcemaps), and every LLM type the plugin imports resolves. @deepseek-ai/dsh itself: identical lib/ (26 files), only the new upgrade guide and its index; runtime dependency count unchanged at 91.
  • Export sets: zero added and zero removed names across all 18 packages, runtime and types.

Development pin 0.2.0-rc.2:

  • pnpm compat:check — supported list, peer ORs, engines.dsh, dev pins and installed packages agree.
  • pnpm test — 80 files, 1047 tests pass.
  • pnpm docs:check — 64 Markdown files, 968 links pass.
  • pnpm build; pnpm test:artifact (7 pass); pnpm pack.

Isolated matrix lane 0.2.2-rc.4 (node scripts/run-dsh-matrix.mjs --online-install …, macOS arm64, Node 24.18.0, pnpm 11.7.0):

  • bootstrap, upgrade, install, pnpm peers check, compat:check, test (80 files / 1047), docs, build, artifact (7) and pack all green.
  • Lane pin 0.2.2-rc.4; runtime pins Cordis 4.1.0 / loader 1.1.0 / include 1.1.0 / group 1.1.0 / timer 1.2.0 / cosmokit 1.9.0 / schemastery 3.19.0.
  • Packed dsh-electron-dsh-plugin-git-0.2.11.tgz, sha256 d06d036458ac802c68518f0176d71b0beb352261c717e168174d15e0c80bdfda.

The compatibility contract records the seam review and this evidence: docs/reference/dsh-compatibility.md.

CI results

  • Compatibility matrix on this draft: all 26 exact releases pass bootstrap, upgrade, install, peers, compat, tests, docs, build, artifact and pack; verify (0.2.2-rc.4) runs on Node 24.9.0.
  • Main CI: macOS, Ubuntu and Windows pass every step, including the pnpm test:e2e browser fixture and the A1–A3 acceptance replays on the development pin.

Not covered

  • No local Linux/Windows run.
  • No full DSH Web/Desktop profile installation on 0.2.2-rc.4 and no real remote accounts.
  • The isolated browser fixture runs in main CI on the development pin only; the rc.4 matrix lane does not run it (no src/ change this round).

- Add 0.2.2-rc.4 to the release list, every DSH peer OR, engines.dsh and the
  optional credentials subset. The release re-issues every manifest at
  0.2.2-rc.4, so its Cordis 4.1.0 / cosmokit 1.9.0 / schemastery 3.19.0 copies
  stay inside the declared ranges without a new OR clause.
- Review the rc.3 -> rc.4 seams: dsh-llm adds the CONTENT_REFUSED failure code
  and the DeepSeek adapter reports it for refusal stops after yielding billed
  usage. The plugin classifies no LLM failure code, so the generic generation
  failure path still handles it and no src/compat branch is added; every other
  consumed package is a manifest-only re-issue and the liveshare worker fix
  stays outside this plugin's surface.
- Run the 0.2.2-rc.4 CI lane on Node 24.9.0 with the other 0.2.2 hosts.
- Document the seam review, the published-package comparison and the green
  isolated lane in the compatibility contract.
- Record that the upgrade matrix passed bootstrap, upgrade, install, peers,
  compat, tests, docs, build, artifact and pack on all 26 exact releases, with
  the 0.2.2-rc.4 lane on Node 24.9.0.
- Record that the main CI ran the browser fixture and the three acceptance
  replays on macOS, Ubuntu and Windows on the development pin; the rc.4 matrix
  lane does not run the browser fixture.
@cherrchen
cherrchen marked this pull request as ready for review November 18, 2026 06:24

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@cherrchen

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T06:28:57.802380Z 7071aa9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 7071aa9f61

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cherrchen
cherrchen merged commit 55cfdf2 into main Nov 18, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant