Repository navigation
feat(compat): support DSH 0.2.2-rc.4 - #32
Merged
Merged
Conversation
- Add 0.2.2-rc.4 to the release list, every DSH peer OR, engines.dsh and the optional credentials subset. The release re-issues every manifest at 0.2.2-rc.4, so its Cordis 4.1.0 / cosmokit 1.9.0 / schemastery 3.19.0 copies stay inside the declared ranges without a new OR clause. - Review the rc.3 -> rc.4 seams: dsh-llm adds the CONTENT_REFUSED failure code and the DeepSeek adapter reports it for refusal stops after yielding billed usage. The plugin classifies no LLM failure code, so the generic generation failure path still handles it and no src/compat branch is added; every other consumed package is a manifest-only re-issue and the liveshare worker fix stays outside this plugin's surface. - Run the 0.2.2-rc.4 CI lane on Node 24.9.0 with the other 0.2.2 hosts. - Document the seam review, the published-package comparison and the green isolated lane in the compatibility contract.
- Record that the upgrade matrix passed bootstrap, upgrade, install, peers, compat, tests, docs, build, artifact and pack on all 26 exact releases, with the 0.2.2-rc.4 lane on Node 24.9.0. - Record that the main CI ran the browser fixture and the three acceptance replays on macOS, Ubuntu and Windows on the development pin; the rc.4 matrix lane does not run the browser fixture.
cherrchen
marked this pull request as ready for review
November 18, 2026 06:24
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the verified compatibility range from
0.2.2-rc.3to the upstream tagdsh-v0.2.2-rc.4, the current0.2.2release candidate. The development pin and committed lockfile stay on0.2.0-rc.2.0.2.2-rc.4is a content-safety release: the only plugin-facing change is the newCONTENT_REFUSEDLLM failure code, which this plugin does not classify, so the adaptation is declarative (release list, peer ORs,engines.dsh, CI lane) plus the seam review and published-package evidence.Interface review (upstream tags)
dsh-v0.2.2-rc.3(38a6a5c965) →dsh-v0.2.2-rc.4(3f321d32bf): 8 commits, 395 files changed in the tree, 117 in the directories this plugin consumes, and of those 110 are manifest version re-issues.vendor/is untouched.refusalstop reason to the newCONTENT_REFUSEDfailure code (previouslyMALFORMED_RESPONSE) and reports billed usage before failing, recorded in the new upgrade guidedocs/upgrade-guide/v0.2.2-rc.3/deepseek-refusal-code/; the experimental liveshare tunnel worker inherits the Host'sELECTRON_RUN_AS_NODE.dsh-llmadds oneCONTENT_REFUSEDentry toLLM_FAILURE_CODES.GenerateOptions,LlmRuntime.stream,Message,MessageId,TextBlock,text-deltaandfinishare unchanged. The plugin imports no failure-code enum and branches on no code: the RPC adapter maps any generation error togit/internaland surfaces the message, so a refusal keeps the existing failure path. Nosrc/compat/branch.ui-conversation,ui-session,ui-settings,ui-settings-plugins,ui-sidebar-right,ui-renderer,ui-slots,ui-primitives,client-connection,client-locale,client-resourcesandapi-session-controller: manifest-only. TheMenuanchor interface, plugin-used primitives,openTab/openResource,useSessions(...byId[id].cwd)andconfigForms.getare unchanged.dsh-subprocess,dsh-subprocess-local,dsh-credentials,dsh-settings,dsh-workspace,dsh-fs,dsh-working-directoryandexperimental/worktree: manifest-only.resolveExecutable/spawn, separate argv, credential key/ref and worktree probes unchanged.4.1.0, cosmokit1.9.0, schemastery3.19.0— identical to rc.3, already inside the declared ranges; no new OR clause.>=24.9.0; the lane joins the other0.2.2hosts on Node24.9.0.Adaptation
0.2.2-rc.4added toSUPPORTED_DSH_RELEASES,CREDENTIALS_SEAM_DSH_RELEASES, every DSH peer OR andengines.dsh.0.2.2-rc.4joins the0.2.2Node24.9.0lane list in.github/workflows/upgrade.yml.src/file changed in this PR; the plugin imports only LLM types and never classifies failure codes.Validation
Published packages:
@deepseek-ai/dsh@0.2.2-rc.4is on npm since 2026-11-17T17:03:03Z (dist-tagnext;latestremains0.2.2-rc.1), and every declared DSH peer is published at0.2.2-rc.4.distmetadata for all of them): 16 of 18 packages differ only inpackage.json;dsh-client-ui-primitivesis byte-identical except its manifest (Menustill readsanchorRef/anchorPoint, zerogetAnchorRectinlib/; all 12 value exports, 6 type exports and 9 glyphs retained);dsh-api-session-controller'slib/typert.host.jsdid not change.dsh-llmis the only peer with a code delta: oneCONTENT_REFUSEDline inLLM_FAILURE_CODES(lib/index.js,lib/types/error.d.ts,lib/types/error.js,src/error.tsplus two sourcemaps), and every LLM type the plugin imports resolves.@deepseek-ai/dshitself: identicallib/(26 files), only the new upgrade guide and its index; runtime dependency count unchanged at 91.Development pin
0.2.0-rc.2:pnpm compat:check— supported list, peer ORs,engines.dsh, dev pins and installed packages agree.pnpm test— 80 files, 1047 tests pass.pnpm docs:check— 64 Markdown files, 968 links pass.pnpm build;pnpm test:artifact(7 pass);pnpm pack.Isolated matrix lane
0.2.2-rc.4(node scripts/run-dsh-matrix.mjs --online-install …, macOS arm64, Node 24.18.0, pnpm 11.7.0):pnpm peers check,compat:check, test (80 files / 1047), docs, build, artifact (7) and pack all green.0.2.2-rc.4; runtime pins Cordis 4.1.0 / loader 1.1.0 / include 1.1.0 / group 1.1.0 / timer 1.2.0 / cosmokit 1.9.0 / schemastery 3.19.0.dsh-electron-dsh-plugin-git-0.2.11.tgz, sha256d06d036458ac802c68518f0176d71b0beb352261c717e168174d15e0c80bdfda.The compatibility contract records the seam review and this evidence:
docs/reference/dsh-compatibility.md.CI results
verify (0.2.2-rc.4)runs on Node24.9.0.pnpm test:e2ebrowser fixture and the A1–A3 acceptance replays on the development pin.Not covered
0.2.2-rc.4and no real remote accounts.src/change this round).