Skip to content

feat(compat): support DSH 0.2.2-rc.3 - #31

Merged
cherrchen merged 2 commits into
mainfrom
feat/adapt-1117
Nov 17, 2026
Merged

cherrchen merged 2 commits into
mainfrom
feat/adapt-1117

Conversation

@cherrchen

@cherrchen cherrchen commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

Summary

Extends the verified compatibility range from 0.2.2-rc.2 to the upstream tag dsh-v0.2.2-rc.3, the current 0.2.2 release candidate. The development pin and committed lockfile stay on 0.2.0-rc.2.

0.2.2-rc.3 is an additive release: no interface this plugin consumes changed, so the adaptation is declarative (release list, peer ORs, engines.dsh, CI lane) plus the seam review and published-package evidence.

Interface review (upstream tags)

  • dsh-v0.2.2-rc.2 (ddac96760b) → dsh-v0.2.2-rc.3 (38a6a5c965): 6 commits, 515 files changed in the tree, 142 in the directories this plugin consumes, and of those only manifests plus additive icon exports and host-composition packages. vendor/ is untouched.
  • Substantive upstream changes: the new experimental @deepseek-ai/dsh-deepseek-chat-import (46 new files) with its workspace.picker Factory, workspace.picker.directoryFlow hole and sidebar.session.action HOC slot, plus a Windows installer restart-status fix.
Seam Result
primitives / icons Additive only: upload-outline artwork and IconUploadOutlineRegular / IconUploadOutlineMedium. Existing exports and props, including Menu's anchorRef / anchorPoint anchor interface, are unchanged.
Client slots / sidebar / workspace New workspace.picker Factory + workspace.picker.directoryFlow (ui-workspace) and sidebar.session.action HOC (ui-sidebar), owned by the new chat-import panel. This plugin imports neither package and registers none of these slots.
Imported client packages ui-conversation, ui-session, ui-settings, ui-settings-plugins, ui-sidebar-right, ui-renderer, ui-slots, connection, locale, resources: manifest-only re-issue. api-session-controller's published lib/typert.host.js gains one type-graph error code for the new package; the /client entry this plugin imports is unchanged.
Host Git / subprocess / credentials / settings / LLM / worktree Manifest-only re-issue; resolveExecutable / spawn, argv discipline, credential key/ref contract and structural worktree probes unchanged.
Shared runtime Cordis 4.1.0, cosmokit 1.9.0, schemastery 3.19.0 — identical to rc.2, already inside the declared ranges; no new OR clause.
Node rc.3 still declares Node >=24.9.0; the lane joins the other 0.2.2 hosts on Node 24.9.0.

Adaptation

  • Declarations. 0.2.2-rc.3 added to SUPPORTED_DSH_RELEASES, CREDENTIALS_SEAM_DSH_RELEASES, every DSH peer OR and engines.dsh.
  • CI. 0.2.2-rc.3 joins the 0.2.2 Node 24.9.0 lane list in .github/workflows/upgrade.yml.
  • No compat branch. The commit-options dropdown's src/compat/dsh-menu.tsx probe keeps selecting ref on rc.3; no src/ file changed in this PR.
  • Not added to peer OR. No plugin peer was added or removed; the new experimental import package is host-composed and not imported.

Validation

Published packages:

  • @deepseek-ai/dsh@0.2.2-rc.3 is on npm since 2026-11-13 (dist-tag next; latest remains 0.2.2-rc.1), and every declared DSH peer is published at 0.2.2-rc.3.
  • Tarball comparison rc.2 vs rc.3: 15 of 17 peers have a byte-identical lib/ (only package.json differs); dsh-api-session-controller adds one type-graph error code to lib/typert.host.js; dsh-client-ui-primitives differs only in lib/index.js plus icon declarations — the two new glyphs (367 other lib/ files identical). @deepseek-ai/dsh itself: identical lib/, docs and manifest differ.
  • On rc.3 the primitives Menu declaration still carries anchorRef / anchorPoint, getAnchorRect appears zero times in lib/, and every plugin-used primitive and icon export is retained.

Development pin 0.2.0-rc.2:

  • pnpm compat:check — supported list, peer ORs, engines.dsh, dev pins and installed packages agree.
  • pnpm test — 80 files, 1047 tests pass.
  • pnpm docs:check — 64 Markdown files, 960 links pass.
  • pnpm build; pnpm test:artifact (7 pass); pnpm pack.

Isolated matrix lane 0.2.2-rc.3 (node scripts/run-dsh-matrix.mjs --online-install …, macOS arm64, Node 24.18.0, pnpm 11.7.0):

  • bootstrap, upgrade, install, pnpm peers check, compat:check, test (80 files / 1047), docs, build, artifact (7) and pack all green.
  • Lane pin 0.2.2-rc.3; runtime pins Cordis 4.1.0 / loader 1.1.0 / include 1.1.0 / group 1.1.0 / timer 1.2.0 / cosmokit 1.9.0 / schemastery 3.19.0.
  • Packed dsh-electron-dsh-plugin-git-0.2.10.tgz, sha256 62cd2a8e0eb0fb1e007b2bb78700cec0df4b517479774c4fc440cb5dd701678f.

The compatibility contract records the seam review and this evidence: docs/reference/dsh-compatibility.md.

CI results

  • Compatibility matrix on this pull request: all 25 exact releases pass bootstrap, upgrade, install, peers, compat, tests, docs, build, artifact and pack; verify (0.2.2-rc.3) runs on Node 24.9.0.
  • Main CI: macOS, Ubuntu and Windows pass every step, including the pnpm test:e2e browser fixture on the development pin.

Not covered

  • No local Linux/Windows run.
  • No full DSH Web/Desktop profile installation on 0.2.2-rc.3 and no real remote accounts.
  • The isolated browser fixture runs in main CI on the development pin only; the 0.2.2-rc.3 matrix lane does not run it (no src/ change this round).

- Add 0.2.2-rc.3 to the release list, every DSH peer OR, engines.dsh and the
  optional credentials subset. The release re-issues every manifest at
  0.2.2-rc.3, so its Cordis 4.1.0 / cosmokit 1.9.0 / schemastery 3.19.0 copies
  stay inside the declared ranges without a new OR clause.
- Review the rc.2 -> rc.3 seams: the only plugin-facing source change is two
  additive ui-primitives upload glyphs. The new workspace.picker /
  sidebar.session.action slots, the chat-import bundle and the Windows
  installer fix stay outside this plugin's surface, and the Menu anchor
  interface is unchanged, so no src/compat branch is added.
- Run the 0.2.2-rc.3 CI lane on Node 24.9.0 with the other 0.2.2 hosts.
- Document the seam review, the published-package comparison and the green
  isolated lane in the compatibility contract.
- Record that the upgrade matrix passed bootstrap, upgrade, install, peers,
  compat, tests, docs, build, artifact and pack on all 25 exact releases, with
  the 0.2.2-rc.3 lane on Node 24.9.0.
- Record that the main CI ran the browser fixture on macOS, Ubuntu and Windows
  on the development pin; the rc.3 matrix lane does not run it.
@cherrchen
cherrchen marked this pull request as ready for review November 17, 2026 10:31

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@cherrchen

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T10:36:03.977685Z 0b5ab8d Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 0b5ab8d7e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@cherrchen
cherrchen merged commit 6271c42 into main Nov 17, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant