Repository navigation
feat(compat): support DSH 0.2.2-rc.3 - #31
Merged
Merged
Conversation
- Add 0.2.2-rc.3 to the release list, every DSH peer OR, engines.dsh and the optional credentials subset. The release re-issues every manifest at 0.2.2-rc.3, so its Cordis 4.1.0 / cosmokit 1.9.0 / schemastery 3.19.0 copies stay inside the declared ranges without a new OR clause. - Review the rc.2 -> rc.3 seams: the only plugin-facing source change is two additive ui-primitives upload glyphs. The new workspace.picker / sidebar.session.action slots, the chat-import bundle and the Windows installer fix stay outside this plugin's surface, and the Menu anchor interface is unchanged, so no src/compat branch is added. - Run the 0.2.2-rc.3 CI lane on Node 24.9.0 with the other 0.2.2 hosts. - Document the seam review, the published-package comparison and the green isolated lane in the compatibility contract.
- Record that the upgrade matrix passed bootstrap, upgrade, install, peers, compat, tests, docs, build, artifact and pack on all 25 exact releases, with the 0.2.2-rc.3 lane on Node 24.9.0. - Record that the main CI ran the browser fixture on macOS, Ubuntu and Windows on the development pin; the rc.3 matrix lane does not run it.
cherrchen
marked this pull request as ready for review
November 17, 2026 10:31
Owner
Author
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the verified compatibility range from
0.2.2-rc.2to the upstream tagdsh-v0.2.2-rc.3, the current0.2.2release candidate. The development pin and committed lockfile stay on0.2.0-rc.2.0.2.2-rc.3is an additive release: no interface this plugin consumes changed, so the adaptation is declarative (release list, peer ORs,engines.dsh, CI lane) plus the seam review and published-package evidence.Interface review (upstream tags)
dsh-v0.2.2-rc.2(ddac96760b) →dsh-v0.2.2-rc.3(38a6a5c965): 6 commits, 515 files changed in the tree, 142 in the directories this plugin consumes, and of those only manifests plus additive icon exports and host-composition packages.vendor/is untouched.@deepseek-ai/dsh-deepseek-chat-import(46 new files) with itsworkspace.pickerFactory,workspace.picker.directoryFlowhole andsidebar.session.actionHOC slot, plus a Windows installer restart-status fix.upload-outlineartwork andIconUploadOutlineRegular/IconUploadOutlineMedium. Existing exports and props, includingMenu'sanchorRef/anchorPointanchor interface, are unchanged.workspace.pickerFactory +workspace.picker.directoryFlow(ui-workspace) andsidebar.session.actionHOC (ui-sidebar), owned by the new chat-import panel. This plugin imports neither package and registers none of these slots.ui-conversation,ui-session,ui-settings,ui-settings-plugins,ui-sidebar-right,ui-renderer,ui-slots,connection,locale,resources: manifest-only re-issue.api-session-controller's publishedlib/typert.host.jsgains one type-graph error code for the new package; the/cliententry this plugin imports is unchanged.resolveExecutable/spawn, argv discipline, credential key/ref contract and structural worktree probes unchanged.4.1.0, cosmokit1.9.0, schemastery3.19.0— identical to rc.2, already inside the declared ranges; no new OR clause.>=24.9.0; the lane joins the other0.2.2hosts on Node24.9.0.Adaptation
0.2.2-rc.3added toSUPPORTED_DSH_RELEASES,CREDENTIALS_SEAM_DSH_RELEASES, every DSH peer OR andengines.dsh.0.2.2-rc.3joins the0.2.2Node24.9.0lane list in.github/workflows/upgrade.yml.src/compat/dsh-menu.tsxprobe keeps selectingrefon rc.3; nosrc/file changed in this PR.Validation
Published packages:
@deepseek-ai/dsh@0.2.2-rc.3is on npm since 2026-11-13 (dist-tagnext;latestremains0.2.2-rc.1), and every declared DSH peer is published at0.2.2-rc.3.lib/(onlypackage.jsondiffers);dsh-api-session-controlleradds one type-graph error code tolib/typert.host.js;dsh-client-ui-primitivesdiffers only inlib/index.jsplus icon declarations — the two new glyphs (367 otherlib/files identical).@deepseek-ai/dshitself: identicallib/, docs and manifest differ.Menudeclaration still carriesanchorRef/anchorPoint,getAnchorRectappears zero times inlib/, and every plugin-used primitive and icon export is retained.Development pin
0.2.0-rc.2:pnpm compat:check— supported list, peer ORs,engines.dsh, dev pins and installed packages agree.pnpm test— 80 files, 1047 tests pass.pnpm docs:check— 64 Markdown files, 960 links pass.pnpm build;pnpm test:artifact(7 pass);pnpm pack.Isolated matrix lane
0.2.2-rc.3(node scripts/run-dsh-matrix.mjs --online-install …, macOS arm64, Node 24.18.0, pnpm 11.7.0):pnpm peers check,compat:check, test (80 files / 1047), docs, build, artifact (7) and pack all green.0.2.2-rc.3; runtime pins Cordis 4.1.0 / loader 1.1.0 / include 1.1.0 / group 1.1.0 / timer 1.2.0 / cosmokit 1.9.0 / schemastery 3.19.0.dsh-electron-dsh-plugin-git-0.2.10.tgz, sha25662cd2a8e0eb0fb1e007b2bb78700cec0df4b517479774c4fc440cb5dd701678f.The compatibility contract records the seam review and this evidence:
docs/reference/dsh-compatibility.md.CI results
verify (0.2.2-rc.3)runs on Node24.9.0.pnpm test:e2ebrowser fixture on the development pin.Not covered
0.2.2-rc.3and no real remote accounts.0.2.2-rc.3matrix lane does not run it (nosrc/change this round).