Fix BLAKE2 with scoped when nimvm branches - #101
Open
ringabout wants to merge 2 commits into
Open
Conversation
Author
|
follows up #83 |
This was referenced Aug 14, 2026
Author
|
There seems to have a pre-existing nimble regression on win32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nim PR nim-lang/Nim#26051 isolates declarations analyzed in retained
when nimvmbranches. BLAKE2 defines its VM and native round implementations inside that conditional and calls them afterward, which now correctly fails with an undeclared identifier.Keep both implementations at module scope and select the procedure-based VM implementation inside each transform. The native backend retains the template-based unrolling.