Repository navigation
fix(site): complete localized legal page depth - #21
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
Changes are limited to static content expansion plus a straightforward test update, with verification indicating the build/test suite passes.
Pull request overview
This PR completes the “trust-anchor” / legal-page substantiiveness contract by extending coverage to the localized Terms pages and expanding Terms copy for Korean, Japanese, and Chinese to meet the >=500 visible-character requirement while keeping the existing layout/content structure.
Changes:
- Extend the “trust anchors” build test to include
termsacross all locale prefixes. - Expand localized Terms content (ko/jp/cn) to cover license scope, unofficial status, user responsibility, warranty/limitations, and change guidance.
File summaries
| File | Description |
|---|---|
site/test/build.test.mjs |
Adds terms to the list of trust-anchor pages validated for substantive visible text. |
site/app/content/legacy-content.json |
Expands localized Terms page content for ko/jp/cn to satisfy the substantiiveness/legal guidance requirements. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
💡 Codex Reviewkmsg/Sources/kmsg/KakaoTalk/ChatWindowResolver.swift Lines 135 to 137 in f9da988 When multiple chats have the same display name, this name-only fast path can return any matching open window before kmsg/Sources/kmsg/Commands/WatchCommand.swift Lines 338 to 341 in f9da988
kmsg/Sources/kmsg/Commands/SendImageCommand.swift Lines 109 to 112 in f9da988 If the target window fails to focus, Cmd-V is not accepted, or the confirmation sheet takes longer than 1.5 seconds to appear, this branch merely sleeps and then prints the success message and may close the window. Those cases are indistinguishable here from a genuine sheetless direct send, so automation receives a false successful-delivery result; verify a transcript/UI state change before taking this path as success. When a logged-out session is recovered while running ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Verification
npm test: Vitest 53 passed, Node 18 passed, typecheck/build passedgit diff --checkReview context
The original trust-anchor requirement named About, Contact, and Privacy, which were already compliant. This follow-up also closes the first independent review’s broader legal-page interpretation so the M-001 table is fully remediated.