refactor: delegate dependency checks to git-pkgs modules - #19
Merged
Conversation
Member
|
Didn't see this until now. Taking a look. |
Member
@andrew does this help you in logging? |
SHA-pinned actions normalize actionPin.version to the trailing comment's tag, so change detection (prior == pin) couldn't see the actual pinned commit. Re-pinning a SHA action to a different commit while keeping the same version comment (or converting a tag pin to this form) was therefore treated as untouched and never checked against latest. Preserve the raw declaration.Version on actionPin as ref, which participates in the equality check without affecting comparison or reporting. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
algomaster99
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves yul's manifest parsing, exact-version checks, latest-version selection, enrichment routing, and GitHub ref resolution onto APIs contributed to the
git-pkgsmodules. The local behavior now comes from released modules instead of parallel implementations.Removing the duplicate code exposed several bugs in yul:
package.jsonsections and repeated uses of a GitHub Action could overwrite one another.These changes depend on work contributed upstream:
git-pkgs/vers#32, released inv0.4.0, adds shared exact-version detection for native constraints.git-pkgs/manifests#74, released inv0.10.0, adds location-aware declarations for npm, PyPI, and GitHub Actions while preserving duplicate declarations.git-pkgs/registries#69, released inv0.8.0, centralizes latest-version selection.git-pkgs/forge#150, released inv0.9.0, adds GitHub ref-to-commit resolution.git-pkgs/enrichment#60, released inv0.7.0, delegates latest-version selection toregistries.The yul integration keeps its existing timeout and User-Agent behavior while delegating those shared responsibilities.