Repository navigation
refactor: compose optional tools by import and preserve failure feedback - #188
Merged
Merged
Conversation
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Ordinary tool failures now remain actionable when a tool also returns partial output, and async/fork failures notify the parent even without a result. Hooks, Agent, AOP and JEV use one small feedback projection while preserving the original Go error, media and explicit control flags. Provider searches require evidence that search actually executed; fallback failures retain their causes.
Browser, passive recon and Katana can be composed through explicit imports without capability build tags. The aiscan
fullproduct composition remains, nativerecordcan compose independently, and passive/CyberHub/crawler dependencies are separated from scanner and general search. Standalone examples exercise each optional extension. Redundant forwarding aliases are removed in favor of their canonical proto/provider types; wire schemas are unchanged.Update CI selectors and package paths for the moved regressions, clean packages newly included in default lint, and fix the harness readiness matcher. Permanent usage and migration documentation is updated. Temporary assessment/RFC/validation reports are excluded.
Refs #148, #173. These references do not close either issue; live model acceptance remains outstanding.
Validation
All 17 CI jobs passed for
899e1951ef146cf10200e6cf46c0111260f213c5: https://github.com/chainreactors/cyber-harness/actions/runs/40205246139. This includes root race/coverage, Windows variants, scanner/JEV regressions, browser and Web E2E, all 18 release archives, and packaged Windows/Linux amd64/arm64 startup and audit single-file checks.go mod tidy -diff,go vet ./...,golangci-lint run --timeout=8m, documentation links, and patch whitespace checks passed locally.Compatibility
Go callers must use
aop.ToolResult/aop.ToolDefinition,agent/provider, andagent/hooksdirectly. Context hooks return[]*aop.Messagewith nil meaning unchanged. Recon declarations move toexts/passive/config; existing config keys and CLI names remain. Vendor structures with independent encoding/validation semantics are retained.