Repository navigation
chore: commit default.pot, drop unused daisyui-theme.js, silence migration test warnings - #88
Merged
Merged
Conversation
The default domain's messages (flash and connection notices, table and close labels) were never extracted, so `mix gettext.extract --check-up-to-date` failed on a clean checkout. errors.pot was already current. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fnjMN7WpEjQJD2zveakV6
phx.new vendored daisyUI's theme plugin, but app.css no longer loads it: themes are the CSS files under assets/css/themes, and the daisyUI plugin runs with `themes: false`. The built CSS and JS are byte-identical without it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019fnjMN7WpEjQJD2zveakV6
Three migration tests passed the migrations path to Ecto.Migrator.run,
which compiles every migration file again on each call. The `test`
alias has already loaded those modules through `ecto.migrate`, so every
full run printed 75 "redefining module" warnings, burying any warning
that mattered.
Textbin.MigrationRepo.migrations/0 compiles the files once per VM and
returns {version, module} pairs, which the migrator accepts in place of
a path. That one load ignores module conflicts for its own duration
only, since it replaces modules with identical code.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019fnjMN7WpEjQJD2zveakV6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small fixes found during the dependency upgrades, one commit each.
chore(gettext): commit the extractedpriv/gettext/default.potmix gettext.extract --check-up-to-datefailed on a clean checkout.errors.potwas already current.chore(assets): removeassets/vendor/daisyui-theme.jsassets/css/themes, and the daisyUI plugin runs withthemes: false.app.cssandapp.jsare byte-identical before and after (sha256).test: load migrations once instead of recompiling them per runEcto.Migrator.run/4, which recompiles every file on each call.testalias has already loaded those modules throughecto.migrate, so every full run printed 75 "redefining module" warnings, which would bury any warning that mattered.Textbin.MigrationRepo.migrations/0(test support) compiles the files once per VM and returns{version, module}pairs, which the migrator accepts in place of a path. It ignores module conflicts only during that one load.Verification
mix precommitpasses: 582 tests, now with 0 warnings in the output (75 before).mix credo --strictreports no issues on the new helper.🤖 Generated with Claude Code
https://claude.ai/code/session_019fnjMN7WpEjQJD2zveakV6
Generated by Claude Code