Skip to content

chore: commit default.pot, drop unused daisyui-theme.js, silence migration test warnings - #88

Merged
darwin67 merged 3 commits into
mainfrom
chore/loose-ends
Oct 12, 2026
Merged

darwin67 merged 3 commits into
mainfrom
chore/loose-ends

Conversation

@darwin67

Copy link
Copy Markdown
Member

Three small fixes found during the dependency upgrades, one commit each.

chore(gettext): commit the extracted priv/gettext/default.pot

  • The default domain's messages were never extracted: the reconnect and error flashes, "Actions" and "close". So mix gettext.extract --check-up-to-date failed on a clean checkout. errors.pot was already current.
  • The check now exits 0.

chore(assets): remove assets/vendor/daisyui-theme.js

  • phx.new vendored it, but nothing loads it any more: themes live in assets/css/themes, and the daisyUI plugin runs with themes: false.
  • The built app.css and app.js are byte-identical before and after (sha256).

test: load migrations once instead of recompiling them per run

  • Three migration tests passed the migrations path to Ecto.Migrator.run/4, which recompiles every file on each call.
  • The test alias has already loaded those modules through ecto.migrate, so every full run printed 75 "redefining module" warnings, which would bury any warning that mattered.
  • Textbin.MigrationRepo.migrations/0 (test support) compiles the files once per VM and returns {version, module} pairs, which the migrator accepts in place of a path. It ignores module conflicts only during that one load.

Verification

  • mix precommit passes: 582 tests, now with 0 warnings in the output (75 before).
  • The three migration test files also pass when run on their own (5 tests).
  • mix credo --strict reports no issues on the new helper.

🤖 Generated with Claude Code

https://claude.ai/code/session_019fnjMN7WpEjQJD2zveakV6


Generated by Claude Code

The default domain's messages (flash and connection notices, table and
close labels) were never extracted, so `mix gettext.extract
--check-up-to-date` failed on a clean checkout. errors.pot was already
current.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019fnjMN7WpEjQJD2zveakV6
phx.new vendored daisyUI's theme plugin, but app.css no longer loads it:
themes are the CSS files under assets/css/themes, and the daisyUI plugin
runs with `themes: false`. The built CSS and JS are byte-identical
without it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019fnjMN7WpEjQJD2zveakV6
Three migration tests passed the migrations path to Ecto.Migrator.run,
which compiles every migration file again on each call. The `test`
alias has already loaded those modules through `ecto.migrate`, so every
full run printed 75 "redefining module" warnings, burying any warning
that mattered.

Textbin.MigrationRepo.migrations/0 compiles the files once per VM and
returns {version, module} pairs, which the migrator accepts in place of
a path. That one load ignores module conflicts for its own duration
only, since it replaces modules with identical code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019fnjMN7WpEjQJD2zveakV6
@github-actions github-actions Bot added the chore label Oct 11, 2026
@darwin67
darwin67 marked this pull request as ready for review October 12, 2026 01:53
@darwin67
darwin67 merged commit 0f683d6 into main Oct 12, 2026
17 checks passed
@darwin67
darwin67 deleted the chore/loose-ends branch October 12, 2026 01:53
@chaba2-bot chaba2-bot Bot mentioned this pull request Oct 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants