Repository navigation
fix(server): reject Antigravity wrappers that chain onto setlocal - #5
Closed
cestercian wants to merge 468 commits into
Closed
cestercian wants to merge 468 commits into
cestercian wants to merge 468 commits into
Conversation
…dotgg#11906) Co-authored-by: T3 Code Test <t3code-test@example.com>
…gg#11381) Co-authored-by: yashranaway <yashranaway@users.noreply.github.com>
…ngdotgg#8309) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#11958) Co-authored-by: Antony <tnybyn@gmail.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
…folders (pingdotgg#12008) The health probe launched the PyInstaller ACP binary every minute and force killed it, leaving about 1 GB of _MEI files per run. The probe now resolves the install on disk without spawning. Each ACP process gets its own temp directory under the profile that is removed when the runtime closes, and the driver sweeps the profile temp root on create. Continues pingdotgg#11657 by Vita Skacel. Owned temp directory approach from pingdotgg#9626 by ariszz. Co-authored-by: Vita Skacel <skacel.vita@gmail.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…ingdotgg#12002) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…gdotgg#11954) Co-authored-by: Cursor <cursoragent@cursor.com>
…g#12808) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…off (pingdotgg#12807) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…s page (pingdotgg#12536) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…2243) Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
…2805) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
pingdotgg#12833) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
…nch (pingdotgg#12623) Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…ngdotgg#12848) Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Custom binaryPath values that point at .cmd/.bat launchers were treated as the ACP process and required localharness_external.exe in the wrapper directory. Resolve the real agy_acp_server.exe (sibling or referenced), pair its same-version harness, and spawn that executable so ACP stdio is not routed through cmd.exe.
A Windows .cmd/.bat next to a stale agy_acp_server.exe was unwrapped to that sibling without reading the launcher. Resolve only a proven batch launch target so a wrapper that points at another release keeps that ACP pair, and reject wrappers whose target cannot be proven.
BATCH_IGNORABLE_LINE matched `setlocal & ...exe` before the unquoted `&` check, so a later launch line could win. Reject command-chain metacharacters first, then ignore genuine setup lines.
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom Windows Antigravity wrappers that chain a launch onto an ignorable setup line such as setlocal are now rejected instead of following a later launch target.
Unquoted command-chain metacharacters are checked before BATCH_IGNORABLE_LINE matching. Control-flow and quote-balance checks are unchanged.