Skip to content

fix(server): follow Windows Antigravity wrappers to the ACP pair - #3

Closed
cestercian wants to merge 465 commits into
mainfrom
cursor/antigravity-cmd-wrapper-8860
Closed

fix(server): follow Windows Antigravity wrappers to the ACP pair#3
cestercian wants to merge 465 commits into
mainfrom
cursor/antigravity-cmd-wrapper-8860

Conversation

@cestercian

@cestercian cestercian commented Sep 21, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Owner

What Changed

Custom Antigravity binaryPath values that point at a Windows .cmd or .bat wrapper are no longer treated as the ACP process.

Resolution follows the launcher to agy_acp_server.exe (same directory, or a path the script invokes), then pairs that file’s same-directory localharness_external.exe. ACP spawn uses the unwrapped executable, so JSON-RPC stdio does not go through cmd.exe. A copied harness next to the wrapper is not enough.

Why

Windows wrappers failed the rigid sibling check, or passed it with a copied harness and then hung on ACP health/session start because resolveSpawnCommand routes .cmd/.bat through cmd.exe /c. Same-version pairing is preserved: the harness is always the sibling of the real ACP executable, including when that executable is the managed release.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes
Open in Web Open in Cursor 

shivamhwp and others added 30 commits September 15, 2026 13:07
@shivamhwp
fix(web): center refresh devices in the empty state (pingdotgg#11808)
bf3be75
@juliusmarminge
fix(mobile): match command palette colors to sheets (pingdotgg#11861)
e33b710
@Bil0000 @shivamhwp
fix(web): keep the composer ready during background worktree setup (p…
ae53072 
…ingdotgg#11883)

Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
@shivamhwp T3 Code Test
fix(desktop): keep the sidebar brand and window buttons aligned (ping…
c1b2210 
…dotgg#11906)

Co-authored-by: T3 Code Test <t3code-test@example.com>
@flamboh
fix(web): drop the filled well behind the sidebar header buttons (pin…
9a6b57b 
…gdotgg#11660)
@shivamhwp
fix(server): explain how to configure a missing Codex executable (pin…
2a264ad 
…gdotgg#11345)
@Michel-Liao
fix(mobile): add missing thread rename action (pingdotgg#11503)
d1790aa
@Michel-Liao
fix(mobile): wait for thread deep link hydration (pingdotgg#11502)
caf8b5d
@dominic-r
fix(mobile): keep iOS chat rows aligned after measurement (pingdotgg#…
d07ffbe 
…11813)
@eimexdev
feat: add customizable soft-tint project monograms (pingdotgg#11845)
438465d
@kridaydave
fix: multiple UI and server bug fixes (pingdotgg#11593)
24b711b
@yashranaway
fix(server): release preview hosts after unanswered requests (pingdot…
7235701 
…gg#11381)

Co-authored-by: yashranaway <yashranaway@users.noreply.github.com>
@juliusmarminge
Preserve diff tree order and collapsed folders (pingdotgg#11931)
3efdcc5
@lnieuwenhuis @juliusmarminge
fix(client-runtime): preserve cached turns and older-page loading (pi…
a5da327 
…ngdotgg#8309)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
@juliusmarminge
chore(deps): bump Clerk stack to latest stable versions (pingdotgg#11956
844203d 
)
@juliusmarminge
fix(mobile): update Reanimated and Worklets (pingdotgg#11957)
b18a560
@TonybynMp4 @Ynaugt @claude
fix(desktop): paste as text no longer doubles the pasted text (pingdo…
96bddf8 
…tgg#11958)

Co-authored-by: Antony <tnybyn@gmail.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
@Bil0000
feat(web): choose queue or steer for follow-up messages (pingdotgg#11964
719a76c 
)
@juliusmarminge
feat(mobile): add v2 preview store builds (pingdotgg#11966)
e6ae764
@juliusmarminge
fix(mobile): block incompatible server connections (pingdotgg#11974)
2c16c1d
@Bil0000
fix(web): keep PR controls readable in narrow panels (pingdotgg#11962)
f0a0ead
@Gigioxx
fix(server): block updates under legacy service launchers (pingdotgg#…
b84f63b 
…11940)
@Bil0000 @juliusmarminge
fix: reduce GitHub quota use with sharing enabled (pingdotgg#11888)
f4600d7 
Co-authored-by: Julius Marminge <julius0216@outlook.com>
@Bil0000 @juliusmarminge
fix(usage): refresh limits when the tab opens (pingdotgg#11928)
87a12b5 
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
@bompus
fix(contracts): avoid Intl.Segmenter in monogram validation (Hermes c…
6f7aaff 
…rash) (pingdotgg#11984)
@juliusmarminge
feat(lint): extend Hermes API bans with a configurable API list (ping…
37a8ab2 
…dotgg#11982)
@im-kvijay
fix(server): reuse Git index metadata during checkpoint capture (ping…
b12c92f 
…dotgg#10792)
@juliusmarminge
refactor: give project monograms their own icon variant (pingdotgg#11993
7a368fe 
)
@juliusmarminge
fix(clients): disable incompatible environments during discovery (pin…
935c55b 
…gdotgg#11990)
@t3dotgg @VitaCodez @claude
fix(antigravity): stop health checks from filling the disk with _MEI …
8c18b5b 
…folders (pingdotgg#12008)

The health probe launched the PyInstaller ACP binary every minute and force killed it, leaving about 1 GB of _MEI files per run. The probe now resolves the install on disk without spawning. Each ACP process gets its own temp directory under the profile that is removed when the runtime closes, and the driver sweeps the profile temp root on create.

Continues pingdotgg#11657 by Vita Skacel. Owned temp directory approach from pingdotgg#9626 by ariszz.

Co-authored-by: Vita Skacel <skacel.vita@gmail.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
maria-rcks and others added 26 commits September 20, 2026 20:34
@maria-rcks
fix(web): skip image inline chip when composer is empty (pingdotgg#12528
c789cd1 
)
@t3-code-bot @extoci
fix(web): only show notice details when text is clipped (pingdotgg#12760
f4d979a 
)

Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Exotic <118054752+extoci@users.noreply.github.com>
@juliusmarminge
fix(devices): recover simulator streams after failures (pingdotgg#12639)
9f73ca3
@juliusmarminge
chore(server): bump device tooling versions (pingdotgg#12809)
1ba471a
@Bil0000
fix: allow more attachments without raising the image payload budget (p…
2b17823 
…ingdotgg#12620)
@juliusmarminge @claude
fix(web): device Reconnect starts one stream instead of two (pingdotg…
051a405 
…g#12808)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge @claude
fix(server): tolerate shutting down an iOS simulator that is already …
58f8981 
…off (pingdotgg#12807)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@maria-rcks @claude
feat(web): use the linked pull request row layout on the pull request…
411da2a 
…s page (pingdotgg#12536)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
@Lucenx9
fix(clients): keep backslashes in copied Codex citations (pingdotgg#1…
2efb817 
…2243)

Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
@maria-rcks @claude
feat(web): truncate branch names and paths in the middle (pingdotgg#1…
f7efb53 
…2805)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
@Gigioxx
fix(web): paste markdown with inline code inside bold, italic, or str…
dca84ef 
…ikethrough (pingdotgg#12290)
@maria-rcks @claude
feat(web): show the pull request refresh spinning in the detail header (
a9ab904 
pingdotgg#12833)

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
@Yash-Singh1
fix(web): dismiss composer suggestions with Escape (pingdotgg#12836)
a4bc7de
@SunkenInTime @devin-ai-integration
@juliusmarminge @claude
fix(mobile): keep the source worktree when starting a thread on a bra…
a6cb1dd 
…nch (pingdotgg#12623)

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@maria-rcks
fix(web): keep composer controls visible while they fit (pingdotgg#12837
6cc7f70 
)
@juliusmarminge
feat(devices): show installed and running tool versions per host (pin…
5c5fa5f 
…gdotgg#12816)
@juliusmarminge
feat(devices): show automatic update progress and host retry (pingdot…
3b836f9 
…gg#12817)
@juliusmarminge
feat(devices): add read-only update discovery and remote ownership (p…
61b25b8 
…ingdotgg#12818)
@juliusmarminge
fix(devices): safely reclaim obsolete managed tool versions (pingdotg…
790be6d 
…g#12819)
@maria-rcks
fix(web): match thread notification icons to sidebar status (pingdotg…
30e3649 
…g#12806)
@maria-rcks @cursoragent
fix(web): move sidebar shelves as one block (pingdotgg#11772)
f391b88 
Co-authored-by: maria-rcks <254055478+maria-rcks@users.noreply.github.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@saphid
fix(web): offer undo after unpinning a thread (pingdotgg#10744)
6b0a04a
@juliusmarminge @claude
feat(web): undo settle, snooze and archive, with a mod+z shortcut (pi…
5781b52 
…ngdotgg#12848)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
@juliusmarminge
fix(mobile): use a proper pull request icon on iOS (pingdotgg#12855)
1eeeabb
@t3-code-bot
test(web): remove redundant favicon test (pingdotgg#12856)
b379b5b
@cestercian
fix(server): follow Windows Antigravity wrappers to the ACP pair
9980e04 
Custom binaryPath values that point at .cmd/.bat launchers were treated as
the ACP process and required localharness_external.exe in the wrapper
directory. Resolve the real agy_acp_server.exe (sibling or referenced),
pair its same-version harness, and spawn that executable so ACP stdio is
not routed through cmd.exe.
@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Sep 21, 2026
@cestercian cestercian closed this Sep 21, 2026
@cursor

cursor Bot commented Sep 21, 2026

Copy link
Copy Markdown

Yep — setlocal & "C:\release-a\agy_acp_server.exe" was matching as ignorable before we looked at the unquoted &. Metacharacter check now runs first, so that wrapper is rejected instead of following a later launch line. Added a regression test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size:XXL vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.