Repository navigation
chore(lint): enable clippy::unreachable lint - #57
Merged
Merged
Conversation
tupe12334
added a commit
that referenced
this pull request
Jul 16, 2026
Resolve Cargo.toml conflict: the unreachable=deny lint from this PR was independently added to main via #57 in the interim. Dedupe to a single entry (keeping main's wording) and keep main's map_err_ignore entry that landed alongside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables
clippy::unreachableatdenylevel, forbidding theunreachable!()macro.mdstoreis a storage engine that already denies every other panicking escape hatch (panic,todo,unwrap_used,expect_used,panic_in_result_fn,unwrap_in_result).unreachable!()was the one remaining macro not yet covered — this closes that gap so unexpected states must surface as recoverableErrvalues instead of aborting the process.The codebase has zero uses of
unreachable!()today, so this is a zero-violation, forward-looking guardrail.Closes #41
This pull request was opened by the "Open issues → fix PRs (owned repos + my orgs)" routine of moadim.