Repository navigation
chore(lint): enable clippy::unimplemented - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unimplemented = "deny"to[lints.clippy]inlib/Cargo.toml, completing the existing no-panic restriction family (panic,unreachable,unwrap_used,expect_used,indexing_slicing,string_slice).Why
unimplemented!()deliberately panics for unfinished code paths. The crate already denies the rest of this family; this closes the remaining gap so an unfinished path must return a proper error instead of crashing the installer at runtime.Verification
cargo clippy --all-targets --all-features— clean, no new violations (nounimplemented!()call sites exist in the codebase).cargo build --all-targets— passes.cargo test— 67 passed, 0 failed.Closes #18
This pull request was opened by the Clippy lint improvements → issue + PR (Rust repos) → Slack routine of moadim.