Repository navigation
chore(lint): enable clippy::dbg_macro - #15
Merged
Merged
Conversation
Member
Author
|
@tupe12334 ready for review when you have a chance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clippy::dbg_macro = "deny"inlib/Cargo.toml's[lints.clippy]table, extending this repo's existing panic/hygiene-focused restriction lints (unwrap_used,expect_used,panic,unreachable,indexing_slicing,string_slice,allow_attributes_without_reason).dbg!(...)debugging macros before they ship —dbg!prints file/line + value to stderr, which is meant for local debugging only and is easy to leave behind accidentally.dbg!usages inlib/src, so this is a no-op today and only guards against regressions.Closes #14
Test plan
cargo clippy --all-targetspasses clean (no new violations)cargo buildsucceedscargo test— 63 + 4 tests passThis pull request was opened by the Clippy lint improvements → issue + PR (Rust repos) → Slack routine of moadim.