Repository navigation
[pull] main from SandAI-org:main - #30
Merged
Merged
Conversation
) Root cause: autotune_at_compile_time=False defers Triton kernel autotuning to first forward pass. Results go to Triton's in-memory cache only — Triton's disk cache for autotune results (check_disk_cache / .autotune.json) is disabled by default (knobs.autotuning.cache=False). Each new pod re-benchmarks all kernel configs: ~3-5 min overhead. Fix: Set TRITON_CACHE_AUTOTUNING=1 in _compilation_context(). This enables Triton's built-in autotune disk cache (Autotuner.check_disk_cache), which writes .autotune.json files to TRITON_CACHE_DIR. Since MagiCompiler already points TRITON_CACHE_DIR to persistent AFS, bake warmup autotune results are automatically reused by verify pods. Flow: Bake: compile → warmup forward → autotune → .autotune.json saved to AFS Verify: load .so → first forward → read .autotune.json → skip benchmark Verified with isolated 2-process experiment: 2.6x speedup on cache hit (1.97s → 0.76s for a simple kernel; real 400B model speedup expected to be much larger due to many more kernels). Also updated piecewise_compiler.py comment to document the full mechanism. Co-authored-by: cenn <cenn@cenndeMacBook-Pro.local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )