Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The schema accepted them from the v0.1/v0.2 drafts; no code in ymf or in Proteus (cekees/main, checked by grep) reads or writes any of them, so a document carrying one said something nobody heard. Now it is told which key. - strong_form: strong_form_expression (superseded by equations; units.py only mentioned it in two docstrings, which now say what it does read), known_analytical_solution, dimensional_check (+ DimensionalCheckDef, DimCheckMethodEnum) - model: unit_systems (+ UnitSystemDef) - discretizations[]: bmi_interface - top level: archive, xdmf, and the Xdmf -> xdmf fold in compose Kept: mesh_generation and roughness_source, which ymf.data_sources reads; they go with the decision on that module. Not on the list but also read by nothing: model.units (convention, default); left for that decision too. Examples heat_equation.ymf and poisson_v02_enriched.ymf drop dimensional_check and bmi_interface; three test fixtures drop strong_form_expression (one moves to equations). New test_a_removed_key_is_refused_by_name loads from a file, so the Xdmf case covers the fold: 8 of 8 cases fail on the schema before this commit. Recorded in docs/changes.md (from #1, merged into this branch). | suite | before (#2) | after | |---------------------|-----------------------------------|-----------------------------------| | every extra | 604 passed, 2 skipped, 1 xfailed | 612 passed, 2 skipped, 1 xfailed | | ymf[spec] alone | 430 passed, 19 skipped, 1 xfailed | 438 passed, 19 skipped, 1 xfailed | | ymf[units] alone | 333 passed, 48 skipped | 333 passed, 48 skipped | | ymf[symbolic] alone | 531 passed, 14 skipped, 1 xfailed | 539 passed, 14 skipped, 1 xfailed | Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2 and #1. This PR's own commit is the last one,
7f68da3 Refuse eight schema keys that nothing reads. The branch merges #1 (23a9038) so the removals can be recorded indocs/changes.md. Merge #1 and #2 first. This PR is independent of #3.The schema accepted these keys from the v0.1 and v0.2 drafts. No code in ymf reads or writes any of them, and a grep of proteus
cekees/mainfinds none either. A document that carries one now gets an error naming the key.strong_form_expressionstrong_formequations, whichymf.symbolicreads.units.pyonly mentioned it in two docstrings.known_analytical_solutionstrong_formsolution_paths.analyticalandvvuq.verification.referencedimensional_checkstrong_formymf.units.check, called by whoever wants itunit_systemsmodelbmi_interfacediscretizations[]archive,xdmf, and theXdmfaliasKept:
mesh_generationandroughness_source. The inventory listed them as dead, butymf.data_sourcesreads both, so they go with the decision on that module. Also read by nothing, not removed:model.units(convention,default). It was not on the approved list, so it waits for the same decision.The two examples that carried
dimensional_checkandbmi_interfacedrop those keys. Three test fixtures dropstrong_form_expression, and one of them moves toequations. The newtest_a_removed_key_is_refused_by_nameloads each case from a file, so theXdmfcase also covers the removed alias. All 8 cases fail against the schema before this commit.ymf[spec]aloneymf[units]aloneymf[symbolic]aloneThese are local runs on macOS arm64. The xfail is the composed-domain test that #3 fixes.
🤖 Generated with Claude Code