Reset the cached encoder when encoding changes - #510
Open
OskarEichler wants to merge 2 commits into
Open
Conversation
santiagorodriguez96
left a comment
santiagorodriguez96
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the patch @OskarEichler!
Out of curiosity, is this an issue you were hitting in a real app, or did you discover it from reading the code? Just to understand if this was impacting users or not.
| @encoder ||= WebAuthn::Encoder.new(encoding) | ||
| end | ||
|
|
||
| attr_writer :encoder |
Contributor
There was a problem hiding this comment.
Is this needed?
| :acceptable_attestation_types, | ||
| :legacy_u2f_appid | ||
|
|
||
| attr_reader :encoding |
Contributor
There was a problem hiding this comment.
I think we should move this to the attr_reader in line 64:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configuration delegates encoder=, but RelyingParty has no writer. Changing encoding after first access also leaves the memoized encoder stale. This adds the intended writer and clears the cache from encoding=. Verified with the full 502-example suite, a focused behavior model, RuboCop, and syntax checks on Ruby 4.0 and Ruby 3.2.11.