[LOW] Invalidate cached ECDSA keys after point mutation - #25
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Invalidate
ECDSA::VerifyKey’s cached OpenSSL public-key wrapper after delegated in-place point mutations. Verification and serialization then use the key state exposed by the mutable point object.Reproduction
After
serializeorverifyinitializes@ec_key, calls such asinvert!mutate the delegated EC point but leave subsequent serialization and verification on the old cached point. A verifier can therefore authenticate with a stale key while exposing a different current point to callers.Verification
Compatibility and breaking changes
Unmutated keys are unchanged. Code that mutates a verification point after warming its cache now verifies and serializes the mutated key instead of the stale pre-mutation key; relying on the stale behavior was unsafe.