[LOW] Discard private material from RSA verification keys - #24
Open
OskarEichler wants to merge 1 commit into
Open
[LOW] Discard private material from RSA verification keys#24OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert parsed RSA verification-key inputs to public-only keys before retaining them. This prevents a verification-only wrapper from preserving and later serializing private key components supplied by a caller.
Reproduction
RSA::VerifyKey.deserialize(private_pem)currently retains the private key, reportsprivate? == true, and emits private PEM fromserialize. That conflicts with the verification-only role and can expose private material when applications serialize, log, cache, or transmit what they expect to be a public key.Verification
SigningKey#verify_keyround trips remain validCompatibility and breaking changes
Signature verification is unchanged. Supplying private PEM to
VerifyKeyno longer preserves private components, so code that incorrectly used the verification wrapper to recover or serialize a private key will stop doing so.