Submit WebAuthn forms with requestSubmit so Turbo can intercept - #140
Merged
santiagorodriguez96 merged 1 commit intoJun 22, 2026
Merged
Conversation
santiagorodriguez96
requested review from
RenzoMinelli,
joaquintomas2003 and
nicolastemciuc
June 19, 2026 16:53
santiagorodriguez96
force-pushed
the
sr--webauthn-elements--support-turbo-streams
branch
from
June 19, 2026 18:03
85369bb to
211a61d
Compare
|
Seems to work for me. |
RenzoMinelli
approved these changes
Jun 22, 2026
santiagorodriguez96
deleted the
sr--webauthn-elements--support-turbo-streams
branch
June 22, 2026 18:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #138.
Details
form.submit()withform.requestSubmit()in both<webauthn-create>and<webauthn-get>. Unlikesubmit(),requestSubmit()dispatches a cancelablesubmitevent, so Turbo (and any othersubmitlistener) canintercept it.
submitevent,requestSubmit()would re-trigger their own handler. Adata-ceremony-completedflag lets the second pass through to the browser/Turbo.