Skip to content

Check and test the FRC and SSNR calculations #9

Open

Description

@allevitan

I do believe that the thresholds for the FRC calculations are kind of done in an ad-hoc way. Someone really needs to dig through the FRC and SSNR calculations and double/triple check that the calculations are correct and have the appropriate flags for 50%-50% comparisons, 100%-100% comparisons, and 100%-ground truth comparisons

Activity

  1. allevitan commented on Apr 17, 2026

    @allevitan
    CollaboratorAuthor

    Along with these checks, I think it would be valuable to make a small command-line tool that can be pointed at two reconstructions .h5 files and which will create and save an frc report with some user input to e.g. select the frc region of two reconstructions.

  2. allevitan commented on Jul 13, 2026

    @allevitan
    CollaboratorAuthor

    Okay, I'm spending some time with the existing PRs on related topics, #45 and #46 . I'd like to fold in some of the changes which were made there by Damian and Maël, plus fix some of the issues noted here.

    From #45:

    • Fold in the options to dataset.split()
    • Add test coverage to dataset.split()
    • Bring over the "find_resolution" function from the new example file so it can spit out a number

    From #46

    • Add the option for a different phase/amplitude normalization window from the calculation window

    New improvements:

    • FIX THE ISSUE with non-square regions giving incorrect FRCs, and confirm that it also works for arbitrary non-orthogonal bases
    • Do a full check for bugs related to a non-equal probe and object basis.
    • Add options to use the full complex-valued channel, the phase channel, or the amplitude channel.
    • Add test coverage to confirm it is working.
    • Change the default apodization to min(1/4 of min(image size), 20 pixels), keeping options for full apodization and an explicit width.
    • Create a registered entry point with installation which can be pointed at two (or three) reconstructions, pops up a widget, and then allows the user to select a region and calculates the FRC. With key option, full complex-valued (default), phase only, or amplitude only. Other options can be added as needed. Should have the option to save the aligned results.
    • Write a plotting function for plotting FRCs including resolution values along the top (half-pitch or full-pitch options)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions