Repository navigation
Conversation
Owner
Author
|
Exact head |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Reversing an earlier defect-only report could downgrade a completed work order to IN_PROGRESS even though net good quantity still met planned quantity.
Change
Derive COMPLETED first from the same net-good-quantity rule used by report posting; preserve existing PENDING/IN_PROGRESS behavior otherwise. No changes to inventory, transactions, outbox, idempotency or accounting policy.
Validation
Regression reproduced before fix. Five new cases cover completed defect-only reversal and replay, good-quantity reversal reopening, remaining active reports, partial quantity and final defect-only reset. Local API full suite 665 tests, typecheck and changed-file lint passed. Independent Astra review and 26 focused production tests passed.
Stacked on #42. Exact head
4729940788912acd6d2c31cfddb4c2e5c93f8928passed all gates in CI run 36288237961: 825 regular tests (18 scripts + 665 API + 142 Web), 77 real PostgreSQL regressions, 13/13 stocked-trade HTTP steps and 9 actual Chromium tests. Actual logs inspected. No deployment/main merge or production-readiness claim.