Repository navigation
fix: capture volumes under concurrent mounts - #96
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
hdiutilimage listing again, waiting at most 1.55 s, when it is inconsistent or missing an image that was just attached. A listing that stays inconsistent is still refused.Verification
main: a failure in each of 3 rounds ("did not mount at its owned path" or "has an unexpected mount"), with mounted images left behind. Traces show the listing missing the image about 20 ms after a successful attach, while the next read lists it.main's modules and pass here: a lagging or half-listed listing, a persistently inconsistent listing still refused, and removal after the capture remounts on another device.generate_adapters --check,render_compatibility --check, the unit suite andgit diff --checkpass.