Repository navigation
fix: guard Copilot-style login for non-Copilot agents; pre-parse PSI before navigation - #1194
Merged
Merged
Conversation
Restoring editor state for a freshly opened file (e.g. Markdown with preview) logs "File should be parsed when changing editor state" and can freeze the UI when the PSI is still unparsed on the EDT. Parse it in a read action on the calling background thread first.
AuthLoginService.resolveAuthCommand() builds '<binary> login', which is only valid for Copilot. For other agents (e.g. OpenCode, which treats the argument as a project directory) it fails with a confusing chdir error. Guard startInlineAuth() and startCopilotLogin() on the active profile's supportsOAuthSignIn flag. Other profiles use their terminalSignInCommand if defined, otherwise show a message to sign in via the CLI and retry. Refs #1193 (defensive part; root cause still being investigated)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
IDE Compatibility Matrix
Generated from the real-IDE integration bench (
Logged IDE errors (non-gating)Scraped from the IDE log during the run. These do not fail a matrix cell (the cell reflects the tool's MCP response) — they are listed for visibility while the bench matures.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Two independent fixes:
AuthLoginServicebuilt<binary> login, which is only valid for Copilot. For OpenCode it fails with achdir ... -> 'login'error.startInlineAuth()/startCopilotLogin()are now gated on the active profile'ssupportsOAuthSignIn; other profiles use theirterminalSignInCommandor show a 'sign in via the CLI' message. Root cause of how the user reached this path is still being investigated (questions posted on the issue), so this does not close it.