Repository navigation
feat: support CodeArtifact domain permissions policies - #12
Conversation
|
Cool beans. Some notes: Must fix:
Should fix:
|
|
More verbose clanker version: main.tf:33 — use a bool to turn on the policyWhen the policy comes from something built in the same run (for example an This also covers two smaller things:
Optional: move this block below the variables.tf:24-25 — description and validationSetting the variable back to null deletes the policy in AWS, so "unmanaged" README.md:44-78 — cross-account example
Also, after these changes, regenerate the terraform-docs table. The current one |
|
@DocMarten if you want a more immediate response from me, feel free to ping me in Discord, but I will try to remember to check this PR periodically as well. Github notifications are awful and I'll entirely miss them most of the time in the sea of noise. |
Add an explicit policy enable flag, domain owner support, and JSON validation. Recreate the policy when its domain is replaced, and clarify cross-account access requirements in the README.
|
@todpunk I’ve updated the PR to: |
|
lol, old Actions stuff in the way. I'm not going to move this to Reactorcide at this activity level, the validation I ran locally is enough. Merging. |
|
Release action also failed because it's just ancient and stupid, so I manually did it. If there's actual interest in active development next time we can convert to Reactorcide. For now, this is fine, I believe. |
Summary
Add optional support for managing a CodeArtifact domain permissions policy.
Callers can pass a complete JSON policy document through
codeartifact_domain_permissions_policy. When omitted, the module does notcreate a policy, preserving existing behavior.
Example