Repository navigation
test: give the 202-turn chat room test 30 seconds - #81
Merged
Merged
Conversation
The pinned message test makes 202 durable turns in order. It takes about half a second on a laptop, but CI on the 1.0.3 merge commit took 5.6 seconds in the quality job, where 81 test files run in parallel under coverage, and the default 5 second limit failed the run. Other tests with this much durable work set their own limit.
 [Low impact] This PR appears safe to merge. SummaryGives the pinned-message test 30 seconds to finish instead of the default 5 seconds.
Reviews (1) · Last reviewed commit: "test: give the 202-turn chat room test 3..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on the 1.0.3 merge commit (run 39142558596) failed in the
qualityjob. The test "keeps the text of a pinned message after newer messages push it out" ran for 5568 ms, and the default limit is 5000 ms.The test makes 202 durable turns in order: one pin and 200 posts, each a SQLite commit. It takes about 0.5 seconds locally, with or without coverage. In the
qualityjob, 81 test files run in parallel under coverage on a shared runner, so the test ran about 10 times slower. The change gives this one test a 30 second limit, astest/effect-recovery.test.tsandtest/instance-retention.test.tsdo for their durable work.Checks
pnpm run checkpasses.test/compare-chat-room.test.tspasses.