Repository navigation
chore: prepare version 1.0.3 - #80
Merged
Merged
Conversation
A reader who checks maturity asks who maintains the package, how a release is published, and what they keep if maintenance stops. One page now answers these questions and asks for more maintainers. The README, the versioning page, and the comparison pages link to the new page and no longer state a count of maintainers. A new test fails when a page states one.
|
Docs7 for cardmagic/solid-objects-js
Commit |
 [Low impact] The PR reaches project documentation and release labels, not runtime workflows. The PR appears safe to merge, with a non-blocking gap in the new documentation test. Findings
Fix with agent prompt### Issue 1
test/maintenance-guide.test.ts:5
`maintainerCount` misses ordinary counts such as “1 maintainer” and “two maintainers.” Those phrases pass even though the new test promises to reject pages that state a maintainer count. Include numeric and plural forms, and add examples that check the matcher itself.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryPrepares documentation release
Reviews (1) · Last reviewed commit: "chore: prepare version 1.0.3" · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| import { describe, expect, it } from "vitest" | ||
|
|
||
| const root = new URL("../", import.meta.url) | ||
| const maintainerCount = /\b(?:one|only|sole|single)\s+maintainer\b/i |
There was a problem hiding this comment.
maintainerCount misses ordinary counts such as “1 maintainer” and “two maintainers.” Those phrases pass even though the new test promises to reject pages that state a maintainer count. Include numeric and plural forms, and add examples that check the matcher itself.
Prompt To Fix With AI
This is a comment left during a code review.
Path: test/maintenance-guide.test.ts
Line: 5
Comment:
**Maintainer counts slip through**
`maintainerCount` misses ordinary counts such as “1 maintainer” and “two maintainers.” Those phrases pass even though the new test promises to reject pages that state a maintainer count. Include numeric and plural forms, and add examples that check the matcher itself.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.The count pattern now finds numerals and plural forms, and a test checks the pattern against examples. The maintenance page test now checks the name and profile link of the lead maintainer. The changelog no longer says that the versioning page links to the maintenance page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/maintenance.md. It tells a reader who maintains the project, how CI checks each change, how a release is published, what the reader keeps if maintenance stops, and how to become a maintainer.docs/versioning.md, and the comparison pages no longer state a count of maintainers. The comparison pages link to the new page in their maturity answer.Checks