Skip to content

Update golangci-lint to v2.13 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miniprow merged 2 commits into from
Aug 20, 2026
Merged

Update golangci-lint to v2.13 #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8cdafb
Update golangci-lint to v2.13
binerbot Aug 20, 2026
e83da4c
Fix linter nits
puerco Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,4 @@ jobs:
- name: Run golangci-lint
uses: golangci/golangci-lint-action@ba0d7d2ec06a0ea1cb5fa41b2e4a3ab91d21278a # v9.3.0
with:
version: v2.11
version: v2.13
2 changes: 1 addition & 1 deletion .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ linters:
- godox
- goheader
- gomoddirectives
- gomodguard
- gomodguard_v2
- goprintffuncname
- gosec
- gosmopolitan
Expand Down
2 changes: 1 addition & 1 deletion client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func TestCall(t *testing.T) {
synthErr error
}{
{"normal", []byte("Hi\n"), nil},
{"normal", nil, errors.New("Superbad HTTP Error!")},
{"http-error", nil, errors.New("Superbad HTTP Error!")},
} {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
Expand Down
7 changes: 4 additions & 3 deletions functions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,17 @@ import (

func TestRepoFromString(t *testing.T) {
t.Parallel()
const cosignRepoURL = "https://github.com/sigstore/cosign"
for _, tc := range []struct {
name string
sut string
expect string
mustErr bool
}{
{"reposlug", "sigstore/cosign", "https://github.com/sigstore/cosign", false},
{"noscheme", "github.com/sigstore/cosign", "https://github.com/sigstore/cosign", false},
{"reposlug", "sigstore/cosign", cosignRepoURL, false},
{"noscheme", "github.com/sigstore/cosign", cosignRepoURL, false},
{"norepo", "github.com/sigstore", "", true},
{"locator", "git+https://github.com/sigstore/cosign@main", "https://github.com/sigstore/cosign", false},
{"locator", "git+https://github.com/sigstore/cosign@main", cosignRepoURL, false},
} {
t.Run(tc.name, func(t *testing.T) {
t.Parallel()
Expand Down