Conversation
Releases often name their binaries differently than the repository: atomdrift-project/scan ships atomscan-<version>-<target>.tar.gz. With no name in the spec, drop only tried the repository name and failed with "no asset found for scan" even though the release had exactly one thing to install. When nothing is named after the repository, use the only installable that ships a variant for the target platform. Several candidates are an error listing their names and the #name syntax to pick one. An explicit name is never second-guessed. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
Rust releases name assets after target triples with the architecture first: loongarch64-unknown-linux-musl, powerpc64le-unknown-linux-gnu, riscv64gc-unknown-linux-gnu. Unknown architectures leaked into the installable name, so drop ls showed bogus entries such as atomscan-2.11.0-loongarch64-unknown next to the real installable. Add loongarch64 (as loong64), powerpc64le, powerpc64 and riscv64gc to the architecture aliases so these assets are grouped as variants of the same installable. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
This is an intentionally empty commit that records release intent. It makes no source changes, its only payload is the git trailers below, which the Carabiner tagger reads when the pull request is merged to create a signed, policy-checked semantic version tag. Removing this commit before merge simply cancels the release request. Tag-commit-as: patch Signed-off-by: Adolfo García Veytia (Puerco) <puerco@carabiner.dev>
miniprow
Bot
added
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: puerco The full list of commands accepted by this bot can be found here. DetailsApproved by a repository administrator.Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release request: patch release
This pull request carries a single, intentionally empty commit that records release intent for this repository. It makes no source changes: its only payload is the trailer block in the commit message, which the Carabiner tagger reads when the pull request is merged.
What happens when this merges
miniprow computes the next version from the repository's existing tags and, once the configured release policies pass, creates the signed tag v0.0.1 (a patch release).
Cancelling the release
Closing this pull request without merging, or dropping the release-intent commit from it, cancels the request. Nothing is tagged until the merge happens.
Opened with
cbn tag --pr