Skip to content

close #152 accepts IEnumerable<KeyValuePair<,>> for QueryMap - #228

Open
donnytian wants to merge 2 commits into
canton7:developfrom
donnytian:develop
Open

donnytian wants to merge 2 commits into
canton7:developfrom
donnytian:develop

Conversation

@donnytian

Copy link
Copy Markdown

Change Proposed:

  1. Change parameter from IDictionary<TKey, TValue> to IEnumerable<KeyValuePair<TKey, TValue>> for RequestInfo.AddQueryMap(...) and RequestInfo.AddQueryCollectionMap(...)
  2. Update method emitters to reflect such change.
  3. Reword diagnostic code and message
  4. Add tests
  5. Update README

@donnytian

Copy link
Copy Markdown
Author

@canton7 CI failed due to package validation, not sure how we can fix this, can we just upgrade the baseline version or just remove it temporarily? Can you please help with that?
In the end, this is not a breaking change I think.

<PackageValidationBaselineVersion>1.5.5</PackageValidationBaselineVersion>

@canton7

canton7 commented Jun 10, 2022

Copy link
Copy Markdown
Owner

I'm afraid I wasn't expecting this and I'm going to be tied up for the next week or two on other things, and this will have to wait. Sorry!

@canton7

canton7 commented Jul 9, 2022

Copy link
Copy Markdown
Owner

Apologies for the delay. This looks great, thanks!

You can squish the package validation warnings with ./build.csx build --updateCompatSuppression, which will update the suppressions XML file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants