SV UI: Add SV frontend UI for switch-over times - #7062
Conversation
JYC11
changed the title
dfordivam
assigned
dfordivam and unassigned
rautenrieth-da,
ray-roestenburg-da,
isegall-da and
martinflorian-da
f2d79e0 to
7d4d640
Compare
| )} | ||
| </form.AppField> | ||
| ))} | ||
| {dsoConfigChanges |
There was a problem hiding this comment.
I was able to lock the proposal even though I don't have any errors, I don't know what's the exact repro but it seem easy to trigger
There was a problem hiding this comment.
I experienced the same bug when working on other forms for another PR but I had no idea how to replicate it
There was a problem hiding this comment.
Perhaps this could be a separate github issue?
|
updated switch over time renders from null (no switch over times) to switch over times set from some switch over times to another switcher over times from some switch over times to no switch over times |
|
fixed the "0001-01-01" issue 
|
|
@pawelperek-da there seems to be a sentinel value/row produced by daml. I got around it by just filtering it out so that it doesn't render but is this the best approach? It doesn't show up when rendering but shows up in json and json-diff view. 
|
|
hey @JYC11 can you explain what switch-over time is and what it does so we can provide better feedback on the best design approach for this feature |
|
@pmunot-da I updated the main PR description with what you requested. Pls check |
b2fd92c to
6833951
Compare
6833951 to
3d3de7c
Compare
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
…ling in different timezone Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
Signed-off-by: JYC11 <jaeyoon.c@gmail.com>
3d3de7c to
52ddf5e
Compare
8 participants
fixes: #4249
Switch-over times let SVs agree on a single time to change Scan-served APIs so that BFT reads stay consistent. This information is stored in key-value pairs with keys being what's changing and value for when everyone changes the API. This PR is the 2nd part of the work in issue 4249 where users are allowed to vote on when to set the switch-over time.
the UI part of the issue is implemented here
Amulet Config and DSO Rules Config changes are near identical so screenshots are only from Amulet Config proposal