Add endpoint to return latest event record time - #6986
Open
mrdziuban wants to merge 4 commits into
Open
Conversation
dfordivam
reviewed
Aug 27, 2026
| "getLatestEventRecordTime returns None when there are no events" in { | ||
| for { | ||
| ctx <- newEventStore() | ||
| latest <- ctx.eventStore.getLatestEventRecordTime(domainMigrationId)(traceContext) |
Contributor
There was a problem hiding this comment.
perhaps a test with just an insertUpdate could be added.
Collaborator
Author
There was a problem hiding this comment.
Good idea, added
mrdziuban
force-pushed
the
mrdziuban/latest-event-record-time/3071
branch
from
August 27, 2026 12:17
eb02ac1 to
1ffabdc
Compare
mrdziuban
force-pushed
the
mrdziuban/latest-event-record-time/3071
branch
from
September 3, 2026 12:08
1ffabdc to
1838fed
Compare
Collaborator
Author
|
@ray-roestenburg-da I think the static checks failure should be fixed by #7024. I just rebased, would you mind running CI again? Thank you! |
Contributor
|
@mrdziuban Please add the new API endpoint to |
Collaborator
Author
Thanks for the reminder, added it. |
Fixes canton-network#3071 Adds a new `/v0/events/latest-record-time` endpoint that finds the latest record time for which `/v0/events` will return events. `ScanEventStore#getLatestEventRecordTime` reuses `resolveCurrentMigrationCap` to ensure it has the same behavior as `getEvents`. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
…ring`. Sphinx doesn't like the plain `type: string`, plus this aligns with the convention used for all other endpoints. Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
Signed-off-by: Matt Dziuban <mrdziuban@gmail.com>
mrdziuban
force-pushed
the
mrdziuban/latest-event-record-time/3071
branch
from
September 4, 2026 11:57
a8872dd to
6cc339a
Compare
| )(implicit tc: TraceContext): Future[Option[CantonTimestamp]] = | ||
| resolveCurrentMigrationCap( | ||
| verdictStore.lastIngestedRecordTime, | ||
| updateHistory.lastIngestedRecordTime, |
Contributor
There was a problem hiding this comment.
Note: Looking at if this is bounded, as long as the ingested record time is advanced at least once, getLastEventRecordTime is bounded. There might be some time where the max has to be retrieved from the DB (before the record time is advanced by ingestion), but I think that is fine.
ray-roestenburg-da
self-requested a review
September 4, 2026 12:15
Collaborator
Author
|
Is it possible the test failure is intermittent? |
Contributor
|
Re-running, you ran into a known intermittent issue (which we've just triaged yesterday). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3071
Adds a new
/v0/events/latest-record-timeendpoint that finds the latest record time for which/v0/eventswill return events.ScanEventStore#getLatestEventRecordTimereusesresolveCurrentMigrationCapto ensure it has the same behavior asgetEvents.I confirmed that the
/v0/events/latest-record-timepath won't conflict with the parameterized/v0/events/{update_id}path -- the Pekko generator for guardrail sorts routes so all static paths appear before any parameterized paths.Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines