feat: serve the registration for explicit disclosure - #29
Open
salindne wants to merge 3 commits into
Open
Conversation
Adds GET /v0/domains/{domain_id}/registration, returning the
RegisteredSynchronizer as a ContractWithState so a buying validator can disclose
it on AmuletRules_BuyMemberTraffic. The buyer is neither signatory nor observer,
and update history drops the created event blob by design, so the ACS store is
the only source.
Orders by created_at desc, contract_id: duplicates are representable during an
operator change, a stale pick would credit the superseded operator, and the
tiebreak keeps every Scan in agreement under bftCall.
Signed-off-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
Reshuffles the wall-clock-time sharding, which is recomputed per run. The previous grouping put SplitwellIntegrationTest under enough co-tenancy to starve its base traffic on the splitwell synchronizer. Signed-off-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
Say what is surprising about the code rather than why the change is right. The reasoning is in the commit messages and the PR. Signed-off-by: Sebastian Lindner <33971232+salindne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ChainSafe/canton-extending-mainnet#42
Summary: Scan serves the
RegisteredSynchronizeratGET /v0/domains/{domain_id}/registrationas aContractWithState, so a buying validator can disclose it onAmuletRules_BuyMemberTraffic; the ACS store is the only source of the created event blob, since update history drops it by design.