fix(maas): clean up node state before removal - #902
Open
xtrusia wants to merge 4 commits into
Open
Conversation
Preserve the FQDN returned by MAAS so downstream removal steps can distinguish it from the short cluster node name. Partial-Bug: LP: #2163212 Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com>
xtrusia
marked this pull request as draft
August 18, 2026 01:29
xtrusia
force-pushed
the
fix/lp2163212-hypervisor
branch
from
August 18, 2026 06:45
6c38e2d to
040eb07
Compare
xtrusia
marked this pull request as ready for review
August 19, 2026 05:10
Remove Nova services and Neutron agents by the MAAS FQDN after the target MicroOVN unit is gone. Verify that the control-plane records no longer exist so retrying node removal cannot silently leave stale state. Partial-Bug: LP: #2163212 Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com>
Disable matching cinder-volume services before removing the Juju unit. Use a healthy Cinder control-plane unit to remove the records afterward and require an empty exact-host postcondition. Partial-Bug: LP: #2163212 Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com>
Remove DB-backed MicroCeph OSDs before deleting their Juju unit. Stop removal when MicroCeph and CRUSH state disagree so unsupported orphan recovery remains visible. Closes-Bug: LP: #2163212 Signed-off-by: Seyeong Kim <seyeong.kim@canonical.com>
xtrusia
force-pushed
the
fix/lp2163212-hypervisor
branch
from
August 19, 2026 08:16
040eb07 to
56e7a3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAAS node removal used the short hostname to clean up services that may be registered with the machine FQDN.
It could also remove Juju units without cleaning up their Cinder service records or MicroCeph OSDs.
This left stale state after the node was removed.
Preserve the FQDN returned by MAAS and use it to remove Nova services and Neutron agents after the target MicroOVN unit has stopped. Verify that no exact-host records remain.
Disable matching Cinder volume services before removing the
cinder-volumeunit. Remove their service records through a healthy Cinder control-plane unit afterward, matching both the short hostname and FQDN.Remove DB-backed MicroCeph OSDs before removing the MicroCeph unit.
Compare the MicroCeph database with the CRUSH tree before making changes and stop removal when the two sources disagree.
Force removal passes the supported MicroCeph safety flags without hiding cleanup failures.
Closes-Bug: LP: #2163212