fix: add telemetry notifications support for manila-data - #896
Open
munirsidd wants to merge 1 commit into
Open
Conversation
- Add `enable-telemetry-notifications` variable to the manila-data terraform
plan
- Add `feature_manager.is_feature_enabled("telemetry")` check in
`DeployManilaDataApplicationStep.extra_tfvars()`
- Reapply manila-data in telemetry feature enable/disable plans when
shared-filesystem is active
- Fix existing unit tests to account for the new telemetry flag
Related-bug: #2162762
Signed-off-by: Munir Siddiqui <munir.siddiqui@canonical.com>
hemanthnakkina
left a comment
hemanthnakkina
left a comment
Collaborator
There was a problem hiding this comment.
For Gazpacho, this change is not required as the measurements are already coming from pollster.
For Epoxy and Caracal,
are the notifications mentioned in [1] coming from manila-data?
[1] https://docs.openstack.org/ceilometer/2025.1/admin/telemetry-measurements.html#openstack-file-share
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add enable-telemetry-notifications variable to the manila-data terraform plan and feature_manager.is_feature_enabled check in extra_tfvars, mirroring the existing cinder-volume pattern. Reapply manila-data in telemetry enable/disable plans when shared-filesystem is active. Fix existing unit tests to account for the new telemetry flag.
Assisted-By: Copilot (Claude Opus 4.6)
Partial-bug: #2162762
QA steps
Links
Jira card: OPEN-4670