feat(config): port PostgreSQL parameter building + resource introspection#182
Draft
marceloneppel wants to merge 2 commits into
Draft
feat(config): port PostgreSQL parameter building + resource introspection#182marceloneppel wants to merge 2 commits into
marceloneppel wants to merge 2 commits into
Conversation
…tion Internalizes PostgreSQL parameter calculation (worker-process auto/cap rules, wal_compression, memory-limit conversion) into the library so ConfigManager owns the full config-build flow instead of stopping at a TODO. Resource discovery (cpu_cores, memory_bytes) moves onto the workload rather than a substrate-specific manager: get_available_memory already lives there, ConfigManager already holds self.workload, and K8sManager doesn't exist yet when ConfigManager is constructed in abstract_charm - so the workload is the only place both substrates can share a single no-branch call site. K8sWorkload gains required unit_name/namespace constructor args so its lightkube Pod/Node lookups can resolve "my own pod" without depending on a charm object reference, mirroring what the K8s charm does today via self.unit.name/self.model.name. lightkube becomes a real (not merely transitive) dependency via a new k8s pyproject extra, matching the version pins the K8s test charm already uses. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Porting the charm's config code into the lib deleted the charm tests that guarded these paths, leaving them unasserted lib-side: - get_available_memory: MemTotal kB -> bytes conversion, and empty input -> 0. - _calculate_worker_process_config with zero cores: auto -> "0", not the 8-fallback. The ported code is faithful (verified byte-for-byte), so these are regression insurance for this branch's resource introspection, not a behaviour change. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
update_configbuilds PostgreSQL'sbootstrap.dcs.postgresql.parametersfrom the unit's CPU and memory, which both charms compute per substrate. This step ports the parameter builder and the substrate resource introspection it depends on.Solution
managers/config.py:_build_postgresql_parameterswith the_calculate_max_*helpers and_calculate_worker_process_config(cpu_cores).get_available_resources() -> tuple[int, int]— VM readsos.cpu_count()and available memory; K8s reads the node/pod via lightkube and raisesDeployedWithoutTrustErroron a 403ApiError.k8soptional extra (lightkube,lightkube-models) mirroring the existingvmextra, plus a regenerateduv.lock.DeployedWithoutTrustErroris raised here and caught at the charm/event layer in the charm-adoption PR (managers-raise convention). Second PR in the update_config stack (baseskl-01-update-config-1-peer-accessors).Checklist