Repository navigation
Fix/juju space preseed - #113
Merged
crypticC0der merged 5 commits intoOct 27, 2026
Merged
Conversation
Closes-Bug: #2138445 Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
matperin
requested changes
Oct 21, 2026
matperin
left a comment
matperin
left a comment
Contributor
There was a problem hiding this comment.
Apart from the two nits the fix seems good to me.
Correct the install handler's status message, matching the update-status wording. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
Pass the preseed document to microovn init through call_microovn_command instead of duplicating the subprocess invocation. Update the unit tests to cover the init helper and cluster commands separately. Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
matperin
approved these changes
Oct 27, 2026
matperin
left a comment
matperin
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the changes, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.