Repository navigation
Fix rejoining removed hostnames and preserve cluster join errors - #112
Merged
crypticC0der merged 1 commit intoOct 28, 2026
Merged
Conversation
crypticC0der
force-pushed
the
fix/lp-2170962-rejoin-pr
branch
from
October 16, 2026 13:07
abb6bd9 to
0d5ced3
Compare
Collaborator
Author
|
test failing due to microovn token distributor version mismatches |
matperin
previously approved these changes
Oct 27, 2026
crypticC0der
force-pushed
the
fix/lp-2170962-rejoin-pr
branch
from
October 27, 2026 16:02
95dabad to
62aac4f
Compare
Collaborator
Author
|
waiting on new token distributor build, then will merge |
crypticC0der
force-pushed
the
fix/lp-2170962-rejoin-pr
branch
4 times, most recently
from
October 28, 2026 19:03
0fcde38 to
4e0857d
Compare
Give every unit a persistent request ID so a replacement unit on a re-added hostname never consumes its predecessor's already-used join token. Advertise the complete scoped key in the hostname field, keeping compatibility with distributors that predate request IDs, and deploy the test distributor from v1/edge. Preserve cluster join errors with redacted diagnostics, reconcile pending token requests on distributor upgrade, and add unit and integration coverage for hostname reuse. Closes-bug: #2170962 Signed-off-by: MJ Ponsonby <mj.ponsonby@canonical.com>
crypticC0der
force-pushed
the
fix/lp-2170962-rejoin-pr
branch
from
October 28, 2026 19:30
4e0857d to
5b3ade0
Compare
matperin
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses LP#2170962: updates token distributor to 0.10 for fresh tokens on hostname reuse, preserves join failures in unit status, and adds regression coverage.
Requires the companion token-distributor release. Library implementation and unit tests live in that repository.
Testing: 145 unit tests and lint pass. An existing integration-test type-check error remains; live integration testing pending.