Skip to content

Remove jobmanager platform provider and integration tests - #653

Merged
cbartz merged 1 commit into
mainfrom
copilot/remove-jobmanager-platform
Nov 19, 2025
Merged

cbartz merged 1 commit into
mainfrom
copilot/remove-jobmanager-platform

Conversation

Copilot AI commented Nov 12, 2025 •

Copy link
Copy Markdown
Contributor

Remove jobmanager platform and related integration tests

This PR removes the jobmanager platform/provider implementation and related integration tests as they are no longer used and not part of any public API.

Changes Made

  • Removed jobmanager integration tests and unit tests
  • Removed jobmanager_provider, jobmanager_api, and JobManagerConfiguration
  • Updated Platform enum to only include GITHUB
  • Simplified platform_factory to only accept GitHub configuration
  • Updated reactive consumer to reject non-GitHub URLs
  • Removed jobmanager from dependencies and configuration files
  • Bumped application version to 0.7.0
  • Improved code quality: Reversed check order in platform_factory for cleaner logic flow

Follow-up Work Identified

Based on code review, the following cleanup opportunities have been identified for future PRs:

  • Remove Platform enum (single value no longer needed)
  • Simplify or remove platform_factory (only one implementation)
  • Analyze and potentially simplify RunnerMetadata usage
  • Remove PlatformProvider abstraction layer

Testing

  • All unit tests pass
  • Static analysis passes
  • Security scan passes (CodeQL - 0 alerts)

Checklist

  • Create inventory of all affected files
  • Remove jobmanager integration tests
  • Update CI workflow
  • Remove jobmanager implementation
  • Update unit tests
  • Run tests - PASSED ✓
  • Update CHANGELOG
  • Bump application version to 0.7.0
  • Code review improvements applied
Original prompt

This section details on the original issue you should resolve

<issue_title>Remove jobmanager platform and related integration tests</issue_title>
<issue_description>Background

The jobmanager platform is no longer used and is not part of any public API. Removing it will reduce maintenance and simplify the test matrix for this repository.

Scope

  • Remove the jobmanager platform/provider implementation (jobmanager_provider).
  • Remove the two integration tests: test_jobmanager_prespawned and test_jobmanager_reactive.
  • Update CI (GitHub Actions), documentation, and related build configuration accordingly.

Checklist

  • Search the repo for jobmanager, jobmanager_provider, test_jobmanager_prespawned, and test_jobmanager_reactive, and produce an inventory of affected files.
  • Remove or skip the two integration test modules and confirm CI is green.
  • Remove jobmanager_provider and all code/config references to the jobmanager platform.
  • Remove jobmanager-related docs, examples, and manifests.
  • Update CI workflows/build files to remove jobmanager from the test matrix.
  • Run full unit and integration tests for remaining platforms, fix any unrelated regressions discovered.
  • Update README and architecture docs, and add a CHANGELOG entry describing this removal.

Branch suggestion: remove/jobmanager-and-tests
Labels: cleanup, refactor
Effort: 1–3 PRs, 4–12 hours depending on cross-repo impacts.

Additional context: This issue initiates complete removal since jobmanager is not exposed as any public API to consumers.
</issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Remove jobmanager platform and related integration tests Remove jobmanager platform provider and integration tests Nov 12, 2025
Copilot AI requested a review from cbartz November 12, 2025 09:28

@cbartz cbartz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbartz
cbartz marked this pull request as ready for review November 12, 2025 09:40
@cbartz

cbartz commented Nov 13, 2025

Copy link
Copy Markdown
Collaborator

@copilot can you bump the application version number ?

Copilot AI commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

@copilot can you bump the application version number ?

Bumped application version from 0.6.3 to 0.7.0 in commit a405175.

Copilot AI requested a review from cbartz November 13, 2025 06:38
Comment thread github-runner-manager/src/github_runner_manager/manager/models.py
Comment thread github-runner-manager/src/github_runner_manager/platform/factory.py Outdated
Comment thread github-runner-manager/tests/unit/platform/test_factory.py

@yanksyoon yanksyoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot please follow up on this preliminary review.

@yanksyoon yanksyoon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Good bot! Thanks

@cbartz
cbartz enabled auto-merge (squash) November 18, 2025 14:59
@cbartz
cbartz disabled auto-merge November 18, 2025 14:59
@cbartz
cbartz force-pushed the copilot/remove-jobmanager-platform branch from d2d97ca to d78d396 Compare November 19, 2025 10:46
@cbartz

cbartz commented Nov 19, 2025

Copy link
Copy Markdown
Collaborator

squashed all commits and force updated branch, as we have the signed commit requirement

@github-actions

Copy link
Copy Markdown
Contributor

TICS Quality Gate

❌ Failed

The following errors have occurred during analysis:

❌ [ERROR 5333] Project database 'github-runner-operator' already is connected to a started TICSQServer process that has not registered a stop time. To avoid data corruption, analysis is aborted. Details of the other TICSQServer process: started at 2025-07-09 14:32:08.000 by user ubuntu.

.github/workflows/tics.yaml / TICS / TICS GitHub Action

@cbartz
cbartz enabled auto-merge (squash) November 19, 2025 15:01
@cbartz
cbartz merged commit 1dbf29f into main Nov 19, 2025
161 of 185 checks passed
@cbartz
cbartz deleted the copilot/remove-jobmanager-platform branch November 19, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove jobmanager platform and related integration tests

5 participants